openshift
[wip]SDN-5789: Set up CMOSuddenStrictConfigValidation to block paths to 4.18
The command to extend the risks from blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yam:
$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.18&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]18' | sort -V | grep -v '^4.18.1$' | grep -v '^4.18.0-ec' | grep -v '^4.18.0-rc' | while read VERSION; do sed "s/4.18.1/${VERSION}/" blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yaml > "blocked-edges/${VERSION}-OVNWithMultipleClusterNetworks.yaml"; done
@hongkailiu: This pull request references SDN-5789 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@hongkailiu: This pull request references SDN-5789 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.
In response to this:
The command to extend the risks from
blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yam:$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.18&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]18' | sort -V | grep -v '^4.18.1$' | grep -v '^4.18.0-ec' | grep -v '^4.18.0-rc' | while read VERSION; do sed "s/4.18.1/${VERSION}/" blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yaml > "blocked-edges/${VERSION}-OVNWithMultipleClusterNetworks.yaml"; done
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@hongkailiu: This pull request references CORENET-5832 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.
In response to this:
The command to extend the risks from
blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yam:$ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.18&arch=amd64' | jq -r '.nodes[] | .version' | grep '^4[.]18' | sort -V | grep -v '^4.18.1$' | grep -v '^4.18.0-ec' | grep -v '^4.18.0-rc' | while read VERSION; do sed "s/4.18.1/${VERSION}/" blocked-edges/4.18.1-OVNWithMultipleClusterNetworks.yaml > "blocked-edges/${VERSION}-OVNWithMultipleClusterNetworks.yaml"; done
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@hongkailiu: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hongkailiu, wking
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [hongkailiu,wking]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Is this going to block all cluster upgrade to 4.18.z, not just ovnk cluster with multiple clusternetworks?
Is this going to block all cluster upgrade to 4.18.z, not just ovnk cluster with multiple clusternetworks?
It won't block them, but it will inform them of the known risk, and the cluster admin can review and decide if they want to reconsider, adjust something in their cluster first, or accept the risk and continue. We are assuming that all 4.17 clusters will be OVN, because 4.17 removed SDN, but if you think there are enough non-OVN 4.17 clusters out there we could add "if you're OVN" PromQL. We are not aware of any "do you have multiple cluster networks?" PromQL, which is why we went with Always with oc commands in the CORENET-5832 Description to allow cluster admins to manually assess their exposure. But if you are aware of PromQL that covers that aspect, please comment in the CORENET ticket to let us know what it is :)
