always_run does not get merged from config/ to jobs/

[danwinship]

In #3068, @zaneb added support for specifying always_run: false in configs/, but it only works right when creating new job files; the logic for merging changes to existing jobs didn't get updated, so once a job has been created, changing the value of always_run in its config will have no effect; you have to manually update the job. (FTR, there are 80 jobs where the config specifies always_run: false but the job itself is currently always_run: true.)

We could change it to always use the value of always_run from the config, but that would require fixing all of the existing configs first; most of them never got updated to specify always_run: false. (There are currently 2804 jobs where the job specifies always_run: false but the config does not.)

Alternatively, we could change it to do merged.AlwaysRun = old.AlwaysRun && new.AlwaysRun (so that if either the config or the pre-existing job specifies always_run: false, then it becomes always_run: false). That would fix the 80 currently-broken jobs without affecting the 2804 "secretly allow-run-false" jobs. Though it doesn't really fix the problem, because it would mean that you can convert existing always-run jobs to not-always-run, but you'd still need manual jobs-file editing when converting a not-always-run job back to always-run. So, meh.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci[bot]]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.