openshift
feat: Add resource limits and requests flags for ACME HTTP01 solver pods
There is no supported overrideArgs to provide resources / limits for the solver pod. With this PR, those are to become accepted args.
Hi @appiepollo14. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@swghosh again, what is the hold-up? By waiting this long, we have the risk of getting merge conflicts. Besides this, how big is this change. Let's go....
/retitle RFE-7060,CM-588: Add --acme-http01-solver-* flags as supported cert-manager controller args
@appiepollo14: This pull request references RFE-7060 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.20.0" version, but no target version was set.
This pull request references CM-588 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.
In response to this:
There is no supported overrideArgs to provide resources / limits for the solver pod. With this PR, those are to become accepted args.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@appiepollo14: This pull request references RFE-7060 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.20.0" version, but no target version was set.
This pull request references CM-588 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.
In response to this:
There is no supported overrideArgs to provide resources / limits for the solver pod. With this PR, those are to become accepted args.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: appiepollo14, lunarwhite, swghosh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [swghosh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/label px-approved /label docs-approved conversed with @snarayan-redhat about this as a requirement for 1.17 docs.
@appiepollo14: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.