cert-manager-operator icon indicating copy to clipboard operation
cert-manager-operator copied to clipboard

Updates the reviewers and approvers

Open TrilokGeer opened this issue 1 year ago • 6 comments

Updates the reviewers and approvers list based on recent contributors and in-active members.

TrilokGeer avatar Aug 22 '24 07:08 TrilokGeer

/lgtm /label docs-approved /label px-approved These changes are non-user facing.

swghosh avatar Aug 22 '24 18:08 swghosh

@lunarwhite @xingxingxia either of you, please help with adding a qe-approved label for this to merge, thanks!

swghosh avatar Aug 22 '24 18:08 swghosh

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 22 '24 18:08 openshift-ci[bot]

@lunarwhite , would you like to be listed as reviewer? I see you actively reviewed some PRs in this repo.

xingxingxia avatar Aug 23 '24 02:08 xingxingxia

@xingxingxia Thanks for nominating me. I'd be fully honored to serve as a reviewer.

@TrilokGeer @swghosh ^^ May I ask for your approval if this request is acceptable?

lunarwhite avatar Aug 26 '24 03:08 lunarwhite

@lunarwhite can you add qe-approved label to this PR? On a follow-up PR, I can add you as reviewer (especially for test/).

swghosh avatar Oct 21 '24 07:10 swghosh

Definitely /label qe-approved

lunarwhite avatar Oct 21 '24 07:10 lunarwhite

/retest-required

Remaining retests: 0 against base HEAD 5f97808f1e9b11df5d65dc5a150fd47a087e6111 and 2 for PR HEAD c9f1100033f6bcbf219d30f3ebf721c9c7975184 in total

openshift-ci-robot avatar Oct 21 '24 11:10 openshift-ci-robot

@TrilokGeer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 21 '24 14:10 openshift-ci[bot]