baremetal-runtimecfg icon indicating copy to clipboard operation
baremetal-runtimecfg copied to clipboard

OCPBUGS-59477: Add deterministic sorting for addresses with identical priority

Open emy opened this issue 5 months ago • 4 comments

When multiple addresses have the same priority, link index, address family, gateway status, and public/private status, sort them alphanumerically by IP address string to ensure deterministic and consistent address selection. This prevents non-deterministic behavior when selecting from multiple addresses with identical characteristics.

emy avatar Nov 21 '25 12:11 emy

@emy: This pull request references Jira Issue OCPBUGS-59477, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When multiple addresses have the same priority, link index, address family, gateway status, and public/private status, sort them alphanumerically by IP address string to ensure deterministic and consistent address selection. This prevents non-deterministic behavior when selecting from multiple addresses with identical characteristics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 21 '25 12:11 openshift-ci-robot

/approve

mkowalski avatar Nov 21 '25 12:11 mkowalski

/lgtm

mkowalski avatar Nov 26 '25 15:11 mkowalski

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emy, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 26 '25 15:11 openshift-ci[bot]

/jira refresh

mkowalski avatar Nov 26 '25 15:11 mkowalski

@mkowalski: This pull request references Jira Issue OCPBUGS-59477, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @rbbratta

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 26 '25 15:11 openshift-ci-robot

/verified later

mkowalski avatar Nov 26 '25 19:11 mkowalski

@mkowalski: /verified later <@username> requires at least one GitHub @username to be specified (it can be a comma delimited list). It indicates the engineer(s) that will be performing the verification. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

In response to this:

/verified later

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 26 '25 19:11 openshift-ci-robot

/verified later @mkowalski

mkowalski avatar Nov 26 '25 19:11 mkowalski

@mkowalski: This PR has been marked to be verified later by @mkowalski.

In response to this:

/verified later @mkowalski

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 26 '25 19:11 openshift-ci-robot

@emy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 26 '25 22:11 openshift-ci[bot]

@emy: Jira Issue OCPBUGS-59477: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-59477 has been moved to the MODIFIED state.

In response to this:

When multiple addresses have the same priority, link index, address family, gateway status, and public/private status, sort them alphanumerically by IP address string to ensure deterministic and consistent address selection. This prevents non-deterministic behavior when selecting from multiple addresses with identical characteristics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Nov 26 '25 22:11 openshift-ci-robot

Fix included in accepted release 4.21.0-0.nightly-2025-12-08-112148

openshift-merge-robot avatar Dec 08 '25 20:12 openshift-merge-robot