MGMT-17560: Append kargs for iSCSI boot

[adriengentil]

Set DHCP on the network interface used for the iSCSI network when installing RHCOS on the disk. This is required to allow boot from an iSCSI volume.

PRs part of this story:

• Validate iSCSI volume eligibility on hosts: https://github.com/openshift/assisted-service/pull/6434
• Report iSCSI host ip address: https://github.com/openshift/assisted-installer-agent/pull/727
• Configure DHCP on iSCSI network interface: https://github.com/openshift/assisted-service/pull/6602
• Workaround DNS issue on first boot: https://github.com/openshift/assisted-service/pull/6603
• Filter out machine networks: TODO

[openshift-ci-robot]

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Set DHCP on the network interface used for the iSCSI network when installing RHCOS on the disk. This is required to allow boot from an iSCSI volume.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [adriengentil]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Set DHCP on the network interface used for the iSCSI network when installing RHCOS on the disk. This is required to allow boot from an iSCSI volume.

PRs part of this story:

• Validate iSCSI volume eligibility on hosts: https://github.com/openshift/assisted-service/pull/6434
• Report iSCSI host ip address: https://github.com/openshift/assisted-installer-agent/pull/727
• Configure DHCP on iSCSI network interface: https://github.com/openshift/assisted-service/pull/6602
• Workaround DNS issue on first boot: https://github.com/openshift/assisted-service/pull/6603
• Filter out machine networks: TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci[bot]]

@adriengentil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-odf-4-16	146b78eb6215c6070d4cc1a0ba439a1c2b01ad36	link	true	/test edge-e2e-metal-assisted-odf-4-16
ci/prow/edge-e2e-metal-assisted-cnv-4-16	146b78eb6215c6070d4cc1a0ba439a1c2b01ad36	link	true	/test edge-e2e-metal-assisted-cnv-4-16

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[adriengentil]

/test edge-unit-test edge-lint edge-subsystem-aws

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.56%. Comparing base (c982f69) to head (ff608b7). Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6602      +/-   ##
==========================================
+ Coverage   68.54%   68.56%   +0.02%     
==========================================
  Files         246      246              
  Lines       36740    36770      +30     
==========================================
+ Hits        25182    25213      +31     
+ Misses       9317     9316       -1     
  Partials     2241     2241              

Files	Coverage Δ
internal/host/hostcommands/install_cmd.go	86.94% <100.00%> (+1.64%)	:arrow_up:

... and 1 file with indirect coverage changes

[adriengentil]

/test edge-unit-test edge-lint edge-subsystem-aws

[adriengentil]

can you validate if we have subsystem tests that may need changes/ update

I don't see any subsystem tests related to installation drives. We may add some later, it you think we need them.

I added more unit tests to improve the coverage of this PR.

[eifrach]

/lgtm

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.18.0-202408071712.p0.gd79f85c.assembly.stream.el9. All builds following this will include this PR.