assisted-installer-agent icon indicating copy to clipboard operation
assisted-installer-agent copied to clipboard

[release-ocm-2.11] MGMT-18839: Retry downloading boot artifacts (#778)

Open CrystalChun opened this issue 1 year ago • 5 comments

Cherry-pick of PR https://github.com/openshift/assisted-installer-agent/pull/778 /cc @gamli75


Adds a retry when downloading the boot artifacts from assisted service in case there are connection issues or a server disruption.

CrystalChun avatar Sep 24 '24 16:09 CrystalChun

@CrystalChun: This pull request references MGMT-18839 which is a valid jira issue.

In response to this:

Cherry-pick of PR https://github.com/openshift/assisted-installer-agent/pull/778 /cc @gamli75

Adds a retry when downloading the boot artifacts from assisted service in case there are connection issues or a server disruption.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 24 '24 16:09 openshift-ci-robot

@CrystalChun: This pull request references MGMT-18839 which is a valid jira issue.

In response to this:

Cherry-pick of PR https://github.com/openshift/assisted-installer-agent/pull/778 /cc @gamli75


Adds a retry when downloading the boot artifacts from assisted service in case there are connection issues or a server disruption.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 24 '24 16:09 openshift-ci-robot

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 59.80%. Comparing base (90e3dab) to head (940a039). Report is 1 commits behind head on release-ocm-2.11.

Files with missing lines Patch % Lines
...rc/commands/actions/download_boot_artifacts_cmd.go 0.00% 15 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.11     #790      +/-   ##
====================================================
- Coverage             59.86%   59.80%   -0.06%     
====================================================
  Files                    74       74              
  Lines                  3705     3712       +7     
====================================================
+ Hits                   2218     2220       +2     
- Misses                 1329     1335       +6     
+ Partials                158      157       -1     
Flag Coverage Δ
59.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/commands/actions/download_boot_artifacts_cmd.go 18.88% <0.00%> (-1.60%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Sep 24 '24 16:09 codecov[bot]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 24 '24 18:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 25 '24 08:09 openshift-ci[bot]