assisted-installer-agent icon indicating copy to clipboard operation
assisted-installer-agent copied to clipboard

OCPBUGS-33146: [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep

Open rwsu opened this issue 1 year ago • 7 comments

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

rwsu avatar Apr 30 '24 20:04 rwsu

@rwsu: This pull request references Jira Issue OCPBUGS-16483, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-16483 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 20:04 openshift-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rwsu Once this PR has been reviewed and has the lgtm label, please assign paul-maidment for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 30 '24 20:04 openshift-ci[bot]

/jira cherrypick OCPBUGS-16483

rwsu avatar Apr 30 '24 21:04 rwsu

@rwsu: Jira Issue OCPBUGS-16483 has been cloned as Jira Issue OCPBUGS-33146. Will retitle bug to link to clone. /retitle OCPBUGS-33146: [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep

In response to this:

/jira cherrypick OCPBUGS-16483

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 21:04 openshift-ci-robot

@rwsu: This pull request references Jira Issue OCPBUGS-33146, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-16483 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-16483 to target a version in 4.15.0, 4.15.z, but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 30 '24 21:04 openshift-ci-robot

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 30 '24 21:04 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jul 30 '24 01:07 openshift-bot

/remove-lifecycle stale

rwsu avatar Aug 21 '24 21:08 rwsu

/jira refresh

rwsu avatar Aug 21 '24 21:08 rwsu

@rwsu: This pull request references Jira Issue OCPBUGS-33146, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-16483 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-16483 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact: /cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Aug 21 '24 21:08 openshift-ci-robot

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 11 '24 18:09 openshift-ci[bot]

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 11 '24 20:09 openshift-ci[bot]

@rwsu: Jira Issue OCPBUGS-33146: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33146 has been moved to the MODIFIED state.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Sep 11 '24 20:09 openshift-ci-robot

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent This PR has been included in build ose-agent-installer-node-agent-container-v4.14.0-202409112037.p0.g4106eb4.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Sep 11 '24 21:09 openshift-bot