openshift
AGENT-1367: Use docker-registry from OCP release
Add support for using the docker-registry image from the OCP release instead of always building a generic registry internally. The implementation follows a priority-based approach for registry selection:
- User-configured imageRegistry.uri (highest priority)
- docker-registry from OCP release (middle priority)
- Internally built registry (fallback)
Changes:
- Add ShouldUseOcpRegistry() helper function to centralize decision logic
- Update CopyRegistryImageIfNeeded() to handle all three registry sources
- Add start-registry.sh wrapper script to execute correct podman command
- Update registry.env to include USE_OCP_REGISTRY flag
- Modify ignition files to use ShouldUseOcpRegistry() helper
- Always copy source images to localhost/registry:latest for disconnected env
The docker-registry image from OCP release requires different podman parameters (-u 0 --entrypoint=/usr/bin/distribution serve /etc/registry/config.yaml), which is handled by the wrapper script based on the USE_OCP_REGISTRY flag.
🤖 Generated with Claude Code
Assisted-by: Claude [email protected] Depends-on: https://github.com/openshift/image-registry/pull/450
@rwsu: This pull request references AGENT-1311 which is a valid jira issue.
In response to this:
Add support for using the docker-registry image from the OCP release instead of always building a generic registry internally. The implementation follows a priority-based approach for registry selection:
- User-configured imageRegistry.uri (highest priority)
- docker-registry from OCP release (middle priority)
- Internally built registry (fallback)
Changes:
- Add ShouldUseOcpRegistry() helper function to centralize decision logic
- Update CopyRegistryImageIfNeeded() to handle all three registry sources
- Add start-registry.sh wrapper script to execute correct podman command
- Update registry.env to include USE_OCP_REGISTRY flag
- Modify ignition files to use ShouldUseOcpRegistry() helper
- Always copy source images to localhost/registry:latest for disconnected env
The docker-registry image from OCP release requires different podman parameters (-u 0 --entrypoint=/usr/bin/distribution serve /etc/registry/config.yaml), which is handled by the wrapper script based on the USE_OCP_REGISTRY flag.
🤖 Generated with Claude Code
Assisted-by: Claude [email protected]
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rwsu: This pull request references AGENT-1311 which is a valid jira issue.
In response to this:
Add support for using the docker-registry image from the OCP release instead of always building a generic registry internally. The implementation follows a priority-based approach for registry selection:
- User-configured imageRegistry.uri (highest priority)
- docker-registry from OCP release (middle priority)
- Internally built registry (fallback)
Changes:
- Add ShouldUseOcpRegistry() helper function to centralize decision logic
- Update CopyRegistryImageIfNeeded() to handle all three registry sources
- Add start-registry.sh wrapper script to execute correct podman command
- Update registry.env to include USE_OCP_REGISTRY flag
- Modify ignition files to use ShouldUseOcpRegistry() helper
- Always copy source images to localhost/registry:latest for disconnected env
The docker-registry image from OCP release requires different podman parameters (-u 0 --entrypoint=/usr/bin/distribution serve /etc/registry/config.yaml), which is handled by the wrapper script based on the USE_OCP_REGISTRY flag.
🤖 Generated with Claude Code
Assisted-by: Claude [email protected] Depends-on: https://github.com/openshift/image-registry/pull/450
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rwsu: This pull request references AGENT-1367 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.
In response to this:
Add support for using the docker-registry image from the OCP release instead of always building a generic registry internally. The implementation follows a priority-based approach for registry selection:
- User-configured imageRegistry.uri (highest priority)
- docker-registry from OCP release (middle priority)
- Internally built registry (fallback)
Changes:
- Add ShouldUseOcpRegistry() helper function to centralize decision logic
- Update CopyRegistryImageIfNeeded() to handle all three registry sources
- Add start-registry.sh wrapper script to execute correct podman command
- Update registry.env to include USE_OCP_REGISTRY flag
- Modify ignition files to use ShouldUseOcpRegistry() helper
- Always copy source images to localhost/registry:latest for disconnected env
The docker-registry image from OCP release requires different podman parameters (-u 0 --entrypoint=/usr/bin/distribution serve /etc/registry/config.yaml), which is handled by the wrapper script based on the USE_OCP_REGISTRY flag.
🤖 Generated with Claude Code
Assisted-by: Claude [email protected] Depends-on: https://github.com/openshift/image-registry/pull/450
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@rwsu: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danielerez, rwsu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [danielerez]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment