openshift
OCPBUGS-53221: Allow spaces in AWS resource tags
Manual cherry-pick of #2124
An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are allowed by AWS's official regex:
https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html
Also includes some API cleanup.
Hello @patrickdillon! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@patrickdillon: Jira Issue OCPBUGS-44199 has been cloned as Jira Issue OCPBUGS-53221. Will retitle bug to link to clone. /retitle OCPBUGS-53221: Allow spaces in AWS resource tags
In response to this:
/jira cherry-pick OCPBUGS-44199
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@patrickdillon: This pull request references Jira Issue OCPBUGS-53221, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Manual cherry-pick of #2124
An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are allowed by AWS's official regex:
https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html
Also includes some API cleanup.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@patrickdillon: This pull request references Jira Issue OCPBUGS-53221, which is invalid:
- expected dependent Jira Issue OCPBUGS-44199 to target a version in 4.19.0, but it targets "4.18.0" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@patrickdillon: This pull request references Jira Issue OCPBUGS-53221, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.z) matches configured target version for branch (4.18.z)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
- release note text is set and does not match the template
- dependent bug Jira Issue OCPBUGS-44199 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-44199 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
- bug has dependents
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, patrickdillon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD d6c84c55a124ab4bd96b1a18c916d3f314f1a95a and 2 for PR HEAD c35e732cbc7ac79fdb96b492fc1fba38792b3cfe in total
/retest-required
Remaining retests: 0 against base HEAD d6c84c55a124ab4bd96b1a18c916d3f314f1a95a and 2 for PR HEAD c35e732cbc7ac79fdb96b492fc1fba38792b3cfe in total
/retest-required
Remaining retests: 0 against base HEAD d6c84c55a124ab4bd96b1a18c916d3f314f1a95a and 2 for PR HEAD c35e732cbc7ac79fdb96b492fc1fba38792b3cfe in total
@patrickdillon: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@patrickdillon: Jira Issue OCPBUGS-53221: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-53221 has been moved to the MODIFIED state.
In response to this:
Manual cherry-pick of #2124
An incorrect regex validation prevents users from specifying AWS tag keys or values that include spaces, which are allowed by AWS's official regex:
https://docs.aws.amazon.com/directoryservice/latest/devguide/API_Tag.html
Also includes some API cleanup.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202505090236.p0.g17498eb.assembly.stream.el9. All builds following this will include this PR.
Fix included in accepted release 4.18.0-0.nightly-2025-05-09-054156
