[release-4.18] OCPBUGS-52347: Add CEL validation for RegistrySources in Image API
This is an automated cherry-pick of #1859
/assign muraee
Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-32158 has been cloned as Jira Issue OCPBUGS-52347. Will retitle bug to link to clone. /retitle [release-4.18] OCPBUGS-52347: Add CEL validation for RegistrySources in Image API
In response to this:
This is an automated cherry-pick of #1859
/assign muraee
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-52347, which is invalid:
- expected dependent Jira Issue OCPBUGS-32158 to target a version in 4.19.0, but it targets "4.18.z" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
This is an automated cherry-pick of #1859
/assign muraee
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
/retest
/retest
/retest
@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/okd-scos-e2e-aws-ovn | 0e88dc1ef63ef9bff1950a22740c9d9b2e9b48bf | link | false | /test okd-scos-e2e-aws-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@muraee Did we need this one still or can we close it?
/jira refresh
@muraee: This pull request references Jira Issue OCPBUGS-52347, which is valid. The bug has been moved to the POST state.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.z) matches configured target version for branch (4.18.z)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
- release note text is set and does not match the template
- dependent bug Jira Issue OCPBUGS-32158 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-32158 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0, 4.19.z
- bug has dependents
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@JoelSpeed I think we need it, the original bug was targeting 4.18 can you please add the necessary labels
/lgtm /label backport-risk-assessed /verified by integration tests validating ratcheting behaviour
@JoelSpeed: This PR has been marked as verified by integration tests validating ratcheting behaviour.
In response to this:
/lgtm /label backport-risk-assessed /verified by integration tests validating ratcheting behaviour
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed, openshift-cherrypick-robot
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-52347 :heavy_check_mark: This pull request was pre-merge verified. :heavy_check_mark: All associated pull requests have merged. :heavy_check_mark: All associated, merged pull requests were pre-merge verified.
Jira Issue OCPBUGS-52347 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. :clock4:
In response to this:
This is an automated cherry-pick of #1859
/assign muraee
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202509060032.p0.ge16f6cc.assembly.stream.el9. All builds following this will include this PR.