openshift
OCPBUGS-34194: Modify api description for join and transit switch subnets
Join and transit switch subnets can be configured at day 2 now and this commit is to modify api description for InternalJoinSubnet and InternalTransitSwitchSubnet to reflect recent changes.
@arghosh93: This pull request references Jira Issue OCPBUGS-34194, which is invalid:
- expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.15" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Join and transit switch subnets can be configured at day 2 now and this commit is to modify api description for InternalJoinSubnet and InternalTransitSwitchSubnet to reflect recent changes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @arghosh93! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@arghosh93: This pull request references Jira Issue OCPBUGS-34194, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.18.0) matches configured target version for branch (4.18.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @anuragthehatter
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: arghosh93 Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/okd-scos-images | b39c83ce88537c7f75966fb1be7ee6bfd4a0b547 | link | true | /test okd-scos-images |
| ci/prow/verify-feature-promotion | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test verify-feature-promotion |
| ci/prow/lint | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test lint |
| ci/prow/build | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test build |
| ci/prow/verify | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test verify |
| ci/prow/unit | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test unit |
| ci/prow/integration | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test integration |
| ci/prow/verify-crd-schema | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test verify-crd-schema |
| ci/prow/minor-images | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test minor-images |
| ci/prow/verify-deps | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test verify-deps |
| ci/prow/images | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test images |
| ci/prow/verify-client-go | bf60857040a588dc93f93987eebdd4b80e922534 | link | true | /test verify-client-go |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@arghosh93: This pull request references Jira Issue OCPBUGS-34194. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
Join and transit switch subnets can be configured at day 2 now and this commit is to modify api description for InternalJoinSubnet and InternalTransitSwitchSubnet to reflect recent changes.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.