api icon indicating copy to clipboard operation
api copied to clipboard

add new feature for the Insights Runtime Extractor

Open tremes opened this issue 1 year ago • 3 comments

This is the feature described in the https://github.com/openshift/enhancements/pull/1584 and there's no new API required by this feature.

tremes avatar Jul 30 '24 10:07 tremes

Hello @tremes! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Jul 30 '24 10:07 openshift-ci[bot]

@tremes Are you targeting 4.17 for your feature? We are branching end of the week so wasn't sure if you wanted to still merge this, or wait until we've branched to 4.18

JoelSpeed avatar Aug 05 '24 08:08 JoelSpeed

@JoelSpeed No. It's 4.18 so I can wait for the branching.

tremes avatar Aug 05 '24 10:08 tremes

/lgtm

JoelSpeed avatar Sep 08 '24 11:09 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 08 '24 11:09 openshift-ci[bot]

/retest-required

Remaining retests: 0 against base HEAD d73f2e11e0be768c1f3eef2bacf73bcd7f24c1cd and 2 for PR HEAD 212398b13a7bab3902f95346b73b9cecb78f5b14 in total

openshift-ci-robot avatar Sep 08 '24 12:09 openshift-ci-robot

/retest-required

Remaining retests: 0 against base HEAD d73f2e11e0be768c1f3eef2bacf73bcd7f24c1cd and 2 for PR HEAD 212398b13a7bab3902f95346b73b9cecb78f5b14 in total

openshift-ci-robot avatar Sep 09 '24 00:09 openshift-ci-robot

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 09 '24 04:09 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409090821.p0.g5852b58.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Sep 09 '24 12:09 openshift-bot