openshift
Add MCP and Config Version columns to MCN output
Hello @dkhater-redhat! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Changes look good, have you tested what the output of an oc get machineconfignodes and oc get machineconfignodes -o wide looks like here?
@dkhater-redhat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Had a conversation with Joel and moved all of the required output columns to priority 0. moved the rest to priority 1 so its available when specifying -o wide
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: djoshy, dkhater-redhat, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408012013.p0.g0b7902a.assembly.stream.el9. All builds following this will include this PR.
