openshift
CFE-921: Remove GCPLabelsTags featureGate and references in APIs
Disabling feature gates checks for configuring GCP labels and tags to make it GA.
@bharath-b-rh: This pull request references CFE-921 which is a valid jira issue.
In response to this:
Disabling feature gates checks for configuring GCP labels and tags to make it GA.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @bharath-b-rh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/hold https://github.com/openshift/gcp-filestore-csi-driver-operator/pull/92
@bharath-b-rh: This pull request references CFE-921 which is a valid jira issue.
In response to this:
Disabling feature gates checks for configuring GCP labels and tags to make it GA.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@JoelSpeed verify CI job is failing with below error, but there are tests present here for the feature. Please let me know if different set of test cases need to be added.
Query component readiness for all test run results for feature gate "GCPLabelsTags" on clusterProfile ["Hypershift" "SelfManagedHA"]
Query component readiness for all test run results for pattern "FeatureGate:GCPLabelsTags]" on variant main.JobVariant{Cloud:"gcp", Architecture:"amd64", Topology:"ha"}
INSUFFICIENT CI testing for "GCPLabelsTags".
F0805 11:04:34.173020 169621 root.go:64] Error running codegen: error: only 0 tests found, need at least 5 for "GCPLabelsTags" on {gcp amd64 ha}
make: *** [Makefile:56: verify-scripts] Error 255
@bharath-b-rh The test here is looking for E2E testing, do you have any E2E testing in the origin test suite? Have QE worked on any E2E tests?
@bharath-b-rh The test here is looking for E2E testing, do you have any E2E testing in the origin test suite? Have QE worked on any E2E tests?
FYI the existing E2E tests in PROW CI, for GCP user-defined labels & tags:
[jiwei@jiwei-thinkpadt14gen4 release]$ grep -E "as: gcp-ipi-.*tags" ci-operator/config/ -rl
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yaml
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.15__multi-nightly.yaml
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__multi-nightly.yaml
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.17__multi-nightly-4.17-upgrade-from-stable-4.17.yaml
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.17__multi-nightly.yaml
[jiwei@jiwei-thinkpadt14gen4 release]$ grep -E "as: gcp-ipi-.*tags" ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.17__multi-nightly.yaml -n -A14
1909:- as: gcp-ipi-labels-tags-filestore-csi-fips-tp-amd-f28-destructive
1910- cron: 32 16 7 * *
1911- steps:
1912- cluster_profile: gcp-qe
1913- dependencies:
1914- OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:multi-latest
1915- dependency_overrides:
1916- OO_INDEX: quay.io/openshift-qe-optional-operators/aosqe-index:v4.17
1917- env:
1918- FEATURE_SET: TechPreviewNoUpgrade
1919- FIPS_ENABLED: "true"
1920- test:
1921- - chain: openshift-e2e-test-qe-destructive
1922- workflow: cucushift-installer-rehearse-gcp-ipi-user-labels-tags-filestore-csi
1923:- as: gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14
1924- cron: 13 9 10,26 * *
1925- steps:
1926- cluster_profile: gcp-qe
1927- dependencies:
1928- OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE: release:multi-latest
1929- dependency_overrides:
1930- OO_INDEX: quay.io/openshift-qe-optional-operators/aosqe-index:v4.17
1931- env:
1932- COMPUTE_NODE_TYPE: t2a-standard-4
1933- FEATURE_SET: TechPreviewNoUpgrade
1934- OCP_ARCH: arm64
1935- test:
1936- - chain: openshift-e2e-test-qe
1937- workflow: cucushift-installer-rehearse-gcp-ipi-user-labels-tags-filestore-csi
[jiwei@jiwei-thinkpadt14gen4 release]$
@jianli-wei Is that you saying that QE approve the promotion of this feature? Are you happy that the feature meets its goals and has sufficient regression testing in place?
@jianli-wei Is that you saying that QE approve the promotion of this feature? Are you happy that the feature meets its goals and has sufficient regression testing in place?
@JoelSpeed Yes, our existing PROW CI tests have the E2E tests enabled already, and I will update my PR for post-installation check of user-defined labels & tags after the feature is ready. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bharath-b-rh, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify
In response to this:
/lgtm /override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD cbdcd0df43e80e4b31d1804e471828ed16fe06dc and 2 for PR HEAD 748eeb79a0c31a8db9da1b7df3bf4115ca4ec9a7 in total
/retest-required
Remaining retests: 0 against base HEAD e69593239e4999456536460ed7291001dd32401a and 1 for PR HEAD 748eeb79a0c31a8db9da1b7df3bf4115ca4ec9a7 in total
@bharath-b-rh: bharath-b-rh unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.
In response to this:
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mrunalp: Overrode contexts on behalf of mrunalp: ci/prow/verify
In response to this:
/override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@bharath-b-rh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202408091314.p0.gd6942fb.assembly.stream.el9. All builds following this will include this PR.
