openshift
SDN-4549: [release-4.14]Backport subnet configs
Hello @bpickard22! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bpickard22: This pull request references SDN-4549 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set.
In response to this:
Clean backport of transit and join subnets to 4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sreber84: This pull request references SDN-4549 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
base on https://github.com/openshift/cluster-network-operator/pull/2473#issuecomment-2289573368
/label qe-approved
@zhaozhanqi: The label(s) /label qe-approve cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?
In response to this:
base on https://github.com/openshift/cluster-network-operator/pull/2473#issuecomment-2289573368
/label qe-approve
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@bpickard22: This pull request references SDN-4549 which is a valid jira issue.
In response to this:
Clean backport of transit and join subnets to 4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@JoelSpeed https://github.com/openshift/cluster-network-operator/pull/2473#issuecomment-2289573368 here is a link to a comment describing qe (@asood-rh) running regression / feature tests. We currently do not plan on backporting the day-2 masquerade subnet changes so all cases have been tested and passed
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpickard22, JoelSpeed, knobunc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed,knobunc]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sreber84: This pull request references SDN-4549 which is a valid jira issue.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references SDN-4549 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.14.z" version, but no target version was set.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references Jira Issue OCPBUGS-41360, which is invalid:
- expected the bug to target the "4.14.z" version, but no target version was set
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected Jira Issue OCPBUGS-41360 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Clean backport of transit and join subnets to 4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references Jira Issue OCPBUGS-41360, which is invalid:
- release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
- expected Jira Issue OCPBUGS-41360 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: This pull request references Jira Issue OCPBUGS-41360, which is valid.
7 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.14.z) matches configured target version for branch (4.14.z)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
- release note type set to "Release Note Not Required"
- dependent bug Jira Issue OCPBUGS-41361 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
- dependent Jira Issue OCPBUGS-41361 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
- bug has dependents
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@bpickard22: Jira Issue OCPBUGS-41360: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-41360 has been moved to the MODIFIED state.
In response to this:
Clean backport of transit and join subnets to 4.14
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.