openshift
OCPBUGS-36809: Add missing auth config fields
The uid and extra fields were added to Kubernetes in 1.29.
These fields should be included in OpenShift as well.
@jonesbr17: This pull request references Jira Issue OCPBUGS-36809, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.17.0) matches configured target version for branch (4.17.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
The
uidandextrafields were added to Kubernetes in 1.29. These fields should be included in OpenShift as well.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @jonesbr17! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rtheis: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jonesbr17 could you please adapt/add tests in config/v1/tests/authentications.config.openshift.io/ExternalOIDC.yaml?
@rtheis: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jonesbr17: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:
-
/test build -
/test e2e-aws-ovn -
/test e2e-aws-ovn-hypershift -
/test e2e-aws-ovn-techpreview -
/test e2e-aws-serial -
/test e2e-aws-serial-techpreview -
/test e2e-upgrade -
/test e2e-upgrade-minor -
/test images -
/test integration -
/test unit -
/test verify -
/test verify-client-go -
/test verify-crd-schema -
/test verify-deps
The following commands are available to trigger optional jobs:
-
/test e2e-azure -
/test e2e-gcp -
/test okd-scos-images
Use /test all to run the following jobs that were automatically triggered:
-
pull-ci-openshift-api-master-build -
pull-ci-openshift-api-master-e2e-aws-ovn -
pull-ci-openshift-api-master-e2e-aws-ovn-hypershift -
pull-ci-openshift-api-master-e2e-aws-ovn-techpreview -
pull-ci-openshift-api-master-e2e-aws-serial -
pull-ci-openshift-api-master-e2e-aws-serial-techpreview -
pull-ci-openshift-api-master-e2e-azure -
pull-ci-openshift-api-master-e2e-gcp -
pull-ci-openshift-api-master-e2e-upgrade -
pull-ci-openshift-api-master-e2e-upgrade-minor -
pull-ci-openshift-api-master-images -
pull-ci-openshift-api-master-integration -
pull-ci-openshift-api-master-unit -
pull-ci-openshift-api-master-verify -
pull-ci-openshift-api-master-verify-client-go -
pull-ci-openshift-api-master-verify-crd-schema -
pull-ci-openshift-api-master-verify-deps
In response to this:
/retest required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@rtheis: changing LGTM is restricted to collaborators
In response to this:
/lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/lgtm
Assigning to @deads2k for approval as he approved the OIDC API changes in the first place.
/assign @deads2k
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jonesbr17, liouk, rtheis Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Assigning to @deads2k for approval as he approved the OIDC API changes in the first place.
/hold
New fields require a new gate to ensure that our implementation and testing are complete prior to bringing new fields into the API. I also haven't seen an explanation of when, if, and how these fields will be made functional and tested on HCP or OCP. We need to get those explained prior to merging.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@jonesbr17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp | 1cb4e17eb2d6b61ab11e138ab9afba0546910405 | link | false | /test e2e-gcp |
| ci/prow/lint | 1cb4e17eb2d6b61ab11e138ab9afba0546910405 | link | true | /test lint |
| ci/prow/verify-feature-promotion | 1cb4e17eb2d6b61ab11e138ab9afba0546910405 | link | true | /test verify-feature-promotion |
| ci/prow/e2e-upgrade-out-of-change | 1cb4e17eb2d6b61ab11e138ab9afba0546910405 | link | true | /test e2e-upgrade-out-of-change |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@jonesbr17: This pull request references Jira Issue OCPBUGS-36809. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
The
uidandextrafields were added to Kubernetes in 1.29. These fields should be included in OpenShift as well.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.