openshift
IR-471: Removing featuregate for chunkSizeMiB config
/cc @flavianmissi https://github.com/openshift/cluster-image-registry-operator/pull/1073
@deepsm007: This pull request references IR-471 which is a valid jira issue.
In response to this:
/cc @flavianmissi I'll open one for image-registry in sometime
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @deepsm007! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@deepsm007: This pull request references IR-471 which is a valid jira issue.
In response to this:
/cc @flavianmissi https://github.com/openshift/cluster-image-registry-operator/pull/1073
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Something is off... from e2e-aws-ovn job:
Observed a panic: &errors.errorString{s:"feature \"ChunkSizeMiB\" is not registered in FeatureGates
/override ci/prow/verify-crd-schema
The only failures here are because of maps and bools, and cannot be fixed.
/override ci/prow/verify
Based on the sippy test runs above, I'm also happy that this is being tested and the verify checks (complaining that this feature doesn't work on Azure) are not something that makes sense in this context
One quick question, are there any other opinions we want to gather before we promote? Perhaps adding QE ack would be good?
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema
The only failures here are because of maps and bools, and cannot be fixed.
/override ci/prow/verify
Based on the sippy test runs above, I'm also happy that this is being tested and the verify checks (complaining that this feature doesn't work on Azure) are not something that makes sense in this context
One quick question, are there any other opinions we want to gather before we promote? Perhaps adding QE ack would be good?
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
One quick question, are there any other opinions we want to gather before we promote? Perhaps adding QE ack would be good?
QE will be testing this before we can confirm to merge the PR. cc @xiuwang is working on this and i'll wait for her feedback
@deepsm007: This pull request references IR-471 which is a valid jira issue.
In response to this:
/cc @flavianmissi https://github.com/openshift/cluster-image-registry-operator/pull/1073
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@deepsm007: This pull request references IR-471 which is a valid jira issue.
In response to this:
/cc @flavianmissi https://github.com/openshift/cluster-image-registry-operator/pull/1073
Tested with cluster-bot using this
cluster-bot]$ oc get clusterversion version NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.17.0-0.test-2024-08-01-193338-ci-ln-xxm7wdb-latest True False 5m24s Cluster version is 4.17.0-0.test-2024-08-01-193338-ci-ln-xxm7wdb-latest cluster-bot]$ oc patch config.image/cluster -p '{"spec":{"storage":{"s3":{"chunkSizeMiB":5}}}}' --type=merge config.imageregistry.operator.openshift.io/cluster patched cluster-bot]$ oc -n openshift-image-registry get config.image/cluster -oyaml | yq .spec.storage.s3 bucket: ci-ln-xxm7wdb-76ef8-77pmb-image-registry-us-east-2-trhxwyqtpsk chunkSizeMiB: 5 encrypt: true region: us-east-2 trustedCA: name: "" virtualHostedStyle: false
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@deepsm007: This pull request references IR-471 which is a valid jira issue.
In response to this:
/cc @flavianmissi https://github.com/openshift/cluster-image-registry-operator/pull/1073
Tested with cluster-bot using this
cluster-bot]$ oc get clusterversion version NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.17.0-0.test-2024-08-01-193338-ci-ln-xxm7wdb-latest True False 5m24s Cluster version is 4.17.0-0.test-2024-08-01-193338-ci-ln-xxm7wdb-latest cluster-bot]$ oc patch config.image/cluster -p '{"spec":{"storage":{"s3":{"chunkSizeMiB":5}}}}' --type=merge config.imageregistry.operator.openshift.io/cluster patched cluster-bot]$ oc -n openshift-image-registry get config.image/cluster -oyaml | yq .spec.storage.s3 bucket: ci-ln-xxm7wdb-76ef8-77pmb-image-registry-us-east-2-trhxwyqtpsk chunkSizeMiB: 5 encrypt: true region: us-east-2 trustedCA: name: "" virtualHostedStyle: false
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should reject ChunkSizeMiB value greater than 5 GiB [Suite:openshift/conformance/parallel/minimal]" only passed 76%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 84%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set maximum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 76%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set minimum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 73%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should not accept invalid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 80%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should reject ChunkSizeMiB value greater than 5 GiB [Suite:openshift/conformance/parallel/minimal]" only passed 84%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 68%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set maximum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 88%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set minimum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 80%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}
Looks like we are picking up the test results correctly now. Percentages are lower than we require to pass automatically but you have QE sign off so I'm happy to merge
/lgtm /override ci/prow/verify-crd-schema /override ci/prow/verify
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deepsm007, flavianmissi, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema
In response to this:
error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should reject ChunkSizeMiB value greater than 5 GiB [Suite:openshift/conformance/parallel/minimal]" only passed 76%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 84%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set maximum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 76%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set minimum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 73%, need at least 95% for "ChunkSizeMiB" on {azure amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should not accept invalid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 80%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should reject ChunkSizeMiB value greater than 5 GiB [Suite:openshift/conformance/parallel/minimal]" only passed 84%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 68%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set maximum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 88%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha} error: "[sig-imageregistry][OCPFeatureGate:ChunkSizeMiB][Conformance][apigroup:imageregistry.operator.openshift.io] Image Registry Config ChunkSizeMiB should set minimum valid ChunkSizeMiB value [Suite:openshift/conformance/parallel/minimal]" only passed 80%, need at least 95% for "ChunkSizeMiB" on {gcp amd64 ha}Looks like we are picking up the test results correctly now. Percentages are lower than we require to pass automatically but you have QE sign off so I'm happy to merge
/lgtm /override ci/prow/verify-crd-schema /override ci/prow/verify
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 02716975a7483d95be7b67e75ca93a3bc447f38f and 2 for PR HEAD 7fdaeeaf4df2f1fc0ecec4775e45f6ad7ed727f1 in total
/retest-required
Remaining retests: 0 against base HEAD 8b2b377d9d42634867e281b57218c372fe432cbe and 1 for PR HEAD 7fdaeeaf4df2f1fc0ecec4775e45f6ad7ed727f1 in total
/retest-required
Remaining retests: 0 against base HEAD 346347bccbc8740da3afff665705afe9c554674b and 0 for PR HEAD 7fdaeeaf4df2f1fc0ecec4775e45f6ad7ed727f1 in total
/hold
Revision 7fdaeeaf4df2f1fc0ecec4775e45f6ad7ed727f1 was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 7461358e2e5c6a9db5a8724406999cc49f1daf0c and 2 for PR HEAD 7fdaeeaf4df2f1fc0ecec4775e45f6ad7ed727f1 in total
/override ci/prow/verify /override ci/prow/verify-crd-schema
Tests are being skipped temporarily to avoid an ordering issue with merging this, but not updating payload CRDs directly. Tests need to be re-enabled once the CRDs are updated in payload.
See https://github.com/openshift/origin/pull/28975 for context
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify, ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify /override ci/prow/verify-crd-schema
Tests are being skipped temporarily to avoid an ordering issue with merging this, but not updating payload CRDs directly. Tests need to be re-enabled once the CRDs are updated in payload.
See https://github.com/openshift/origin/pull/28975 for context
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.