openshift
OCPBUGS-29774: Add Intermediate HyperShiftIndependent Profile
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed is a different offering, however, and we would like to correct this so that (1) the profiles can diverge if necessary and (2) the cluster profile name makes sense. This change establishes a "HypershiftIndependent" profile using the improved profile annotation name "include.release.openshift.io/hypershift" . Dozens of other changes across the product have already been introduced to use this annotation in their manifests - openshift/api needs to support it now. Once this change has merged, "include.release.openshift.io/hypershift" can be tested. We will be able to find any overlooked manifests and annotate them. Once the HyperShift team believes the new annotation can be treated as canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") and replace it with ClusterProfileName("include.release.openshift.io/hypershift").
@jupierce: This pull request references Jira Issue OCPBUGS-29774, which is invalid:
- expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed is a different offering, however, and we would like to correct this so that (1) the profiles can diverge if necessary and (2) the cluster profile name makes sense. This change establishes a "HypershiftIndependent" profile using the improved profile annotation name "include.release.openshift.io/hypershift" . Dozens of other changes across the product have already been introduced to use this annotation in their manifests - openshift/api needs to support it now.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hello @jupierce! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jupierce Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed")
Is the annotation used at all by ROKS? Is eliminating this actually a good idea?
@jupierce: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test verify |
| ci/prow/e2e-aws-serial | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-serial-techpreview | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-upgrade | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-ovn | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-upgrade-minor | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-ovn-hypershift | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-ovn-techpreview | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/minor-e2e-upgrade-minor | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/minor-images | c01b540c398a5af09329b62a4dd0fcb751df4da2 | link | true | /test minor-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@jupierce: This pull request references Jira Issue OCPBUGS-29774. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
For historical reasons, "include.release.openshift.io/ibm-cloud-managed" was used as a basis when creating the productized HyperShift installation profile. ibm-cloud-managed is a different offering, however, and we would like to correct this so that (1) the profiles can diverge if necessary and (2) the cluster profile name makes sense. This change establishes a "HypershiftIndependent" profile using the improved profile annotation name "include.release.openshift.io/hypershift" . Dozens of other changes across the product have already been introduced to use this annotation in their manifests - openshift/api needs to support it now. Once this change has merged, "include.release.openshift.io/hypershift" can be tested. We will be able to find any overlooked manifests and annotate them. Once the HyperShift team believes the new annotation can be treated as canonical, we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") and replace it with ClusterProfileName("include.release.openshift.io/hypershift").
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.