api icon indicating copy to clipboard operation
api copied to clipboard

MCO-993: MachineOSImage API

Open cdoern opened this issue 1 year ago • 6 comments

machineOSBuild and Image are meant to represent the two components of an on cluster build, making this commit the user-facing API for on cluster builds. MOSBuilds comprise of the actual processes of kicking off an monitoring a build. A build also contains user options like the push/pull spec for reg> is the result of a build. the Image objects are intended to be trackable and easily related to an MCP. The goal here is to remove much of the split state reporting for on cluster builds and consolidate where the user sets config options.

a MOSImage is the result of a build. the Image objects are intended to be trackable and easily related to an MCP. The goal here is to remove much of the split state reporting for on cluster builds and consolidate where the user sets config options. These images have status conditions as well related to their Age and their Rollout to the nodes on a pool. The valid conditions are "RollingOut", "RolledOut", "RolloutFailed". There is also an "Age" printer column detailing the age of the image.

cdoern avatar Feb 28 '24 14:02 cdoern

Hello @cdoern! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Feb 28 '24 14:02 openshift-ci[bot]

@cdoern: This pull request references MCO-993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

machineOSBuild and Image are meant to represent the two components of an on cluster build, making this commit the user-facing API for on cluster builds. MOSBuilds comprise of the actual processes of kicking off an monitoring a build. A build also contains user options like the push/pull spec for reg> is the result of a build. the Image objects are intended to be trackable and easily related to an MCP. The goal here is to remove much of the split state reporting for on cluster builds and consolidate where the user sets config options.

a MOSImage is the result of a build. the Image objects are intended to be trackable and easily related to an MCP. The goal here is to remove much of the split state reporting for on cluster builds and consolidate where the user sets config options. These images have status conditions as well related to their Age and their Rollout to the nodes on a pool. The valid conditions are "RollingOut", "RolledOut", "RolloutFailed". There is also an "Age" printer column detailing the age of the image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 28 '24 14:02 openshift-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cdoern Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 28 '24 14:02 openshift-ci[bot]

@cdoern: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test integration
ci/prow/verify 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test verify
ci/prow/e2e-upgrade-minor 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 13:03 openshift-ci[bot]

/cc @hexfusion

hexfusion avatar Apr 30 '24 15:04 hexfusion

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Apr 30 '24 15:04 openshift-merge-robot

@cdoern: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test integration
ci/prow/verify 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test verify
ci/prow/e2e-upgrade-minor 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-upgrade-minor
ci/prow/e2e-upgrade 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-upgrade
ci/prow/e2e-aws-ovn-hypershift 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 26bc26801a9f2fb478704a3f63310c4f328ab6a8 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 15:08 openshift-ci[bot]