api icon indicating copy to clipboard operation
api copied to clipboard

Update comment verbiage to be in sync with other platforms

Open pawanpinjarkar opened this issue 2 years ago • 5 comments

Update comment verbiage to be in sync with other platforms.

pawanpinjarkar avatar Aug 30 '23 15:08 pawanpinjarkar

Hello @pawanpinjarkar! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Aug 30 '23 15:08 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar Once this PR has been reviewed and has the lgtm label, please assign jwforres for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 30 '23 15:08 openshift-ci[bot]

CRD schema generation is out of date, please run make update

JoelSpeed avatar Sep 15 '23 10:09 JoelSpeed

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 09:06 openshift-bot

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test verify
ci/prow/e2e-aws-ovn-techpreview d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-upgrade
ci/prow/e2e-upgrade-minor d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift d522f18e54e31665c4c0b1f47f3c69a7db913a63 link true /test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 16:07 openshift-ci[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 08:08 openshift-bot

@pawanpinjarkar Can we get this updated and try to get it merged?

JoelSpeed avatar Aug 12 '24 07:08 JoelSpeed

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Sep 15 '24 08:09 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 15 '24 08:09 openshift-ci[bot]