openshift
OCPNODE-1515 : Support Evented PLEG feature in Openshift
- CRI-O sends the container events to the Kubelet so that the pod cache can be updated based on the received events. More about the Evented PLEG is here - KEP Reference
- This feature can be enabled in OCP by adding a new field in the node config custom resource that can be monitored by the MCO and update both the Kubelet and CRI-O configurations Enhancement PR: https://github.com/openshift/enhancements/pull/1368
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @sairameshv! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
How does this interact with #1471? What's the goal in 4.14?
Looks like 1471 enabled the feature by default in tech preview clusters, so is the intention here that a user will have the choice? It will be on by default but can be disabled by using the fields added here?
How does this interact with #1471? What's the goal in 4.14?
Looks like 1471 enabled the feature by default in tech preview clusters, so is the intention here that a user will have the choice? It will be on by default but can be disabled by using the fields added here?
https://github.com/openshift/api/pull/1471 Just provides a way to enable this feature via featuregate. I don't think it enables the EventedPLEG without getting this PR & the related MCO PR merged. Default behavior of the EventedPLEG is disabled in the cluster.
I don't think it enables the EventedPLEG without getting this PR & the related MCO PR merged.
It does enable it for TechPreviewNoUpgrade clusters. MCO gets the feature gate passed through to kubelet and so it gets enabled by default on any TechPreviewNoUpgrade cluster, guessing that wasn't the intention?
Note, this has been noticed because of debugging issues in openshift/machine-config-operator#3688
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sairameshv Once this PR has been reviewed and has the lgtm label, please assign mfojtik for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sairameshv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-upgrade-minor | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-aws-ovn-techpreview | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-serial-techpreview | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-aws-serial | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn-hypershift | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-upgrade-minor | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-upgrade | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test e2e-upgrade |
| ci/prow/minor-e2e-upgrade-minor | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/minor-images | 8b0fb6b813586781e8a17f93eb4434a9788dedec | link | true | /test minor-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.