osh-js icon indicating copy to clipboard operation
osh-js copied to clipboard

Creating a VideoView creates an unnecessary div

Open nickgaray opened this issue 3 years ago • 1 comments

On Creating a video view, the base class View constructor is invoked, generating an id for the view, then calling init. Within init a div is created and this views id is assigned to it. This ends up creating an unnecessary div node that is not used in the presentation as VideoView creates a canvas and attaches it to the div with the given container id.

This makes having multiple videos create as many divs that are not used at all

nickgaray avatar Dec 02 '22 20:12 nickgaray

This is a generic behavior into the Toolkit, not just for Video. The super class View create the div and provide it to the sub-classes.

The main idea is to have a user container and create an internal div with everything we want inside w/o modifying the user div (because of side effects).

mdhsl avatar Dec 02 '22 21:12 mdhsl