Fix unit test in PowerBI connector.

[Yury-Fridlyand]

Signed-off-by: Yury-Fridlyand [email protected]

Description

Last time we updated PowerBI connector, we missed to update embedded unit tests. These tests may be executed by a developer only. To run tests you need to install PowerQuerySDK for Visual Studio, open mproj file (bi-connectors/PowerBIConnector/src/OpenSearchProject.mproj) with Visual Studio and run it.

Issues Resolved

Before

After

Check List

• [ ] New functionality includes testing.
  • [x] All tests pass, including unit test, integration test and doctest
• [ ] New functionality has been documented.
  • [ ] New functionality has javadoc added
  • [ ] New functionality has user manual doc added
• [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #800 (019c01b) into main (4e40ed2) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #800   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
  Complexity     2910     2910           
=========================================
  Files           288      288           
  Lines          7830     7830           
  Branches        570      570           
=========================================
  Hits           7427     7427           
  Misses          349      349           
  Partials         54       54           

Flag	Coverage Δ
query-workbench	62.76% <ø> (ø)
sql-engine	97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Yury-Fridlyand]

Thanks for the fix! Wondering if we can run this UT automatically in Github action? Is this UT or IT that requires PowerBI instance?

It is a kind of IT. These tests require Visual Studio, PowerQuery SDK and an OpenSearch cluster running, PowerBI is not required. Unfortunately, I don't know how to run these tests in headless mode (without UI) and/or without Visual Studio.