sql icon indicating copy to clipboard operation
sql copied to clipboard

Update maintainer list

Open dai-chen opened this issue 3 years ago • 2 comments

Description

Following https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition to update maintainer list with nominees.

Issues Resolved

N/A

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dai-chen avatar Jul 13 '22 18:07 dai-chen

Codecov Report

Merging #687 (1292df3) into main (8d9b459) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #687   +/-   ##
=========================================
  Coverage     94.74%   94.74%           
  Complexity     2857     2857           
=========================================
  Files           283      283           
  Lines          7676     7676           
  Branches        561      561           
=========================================
  Hits           7273     7273           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d9b459...1292df3. Read the comment docs.

codecov-commenter avatar Jul 13 '22 18:07 codecov-commenter

!!! NOTE !!!: Blocking this PR until we finish the first and second step in https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md#addition

dai-chen avatar Jul 14 '22 18:07 dai-chen

@dblock As the final step below, do you know how can I find repo admin to change the permission for the new maintainers?

The repo admin adjusts the new maintainer’s permissions accordingly, and merges the pull request.

dai-chen avatar Sep 08 '22 20:09 dai-chen

~@dai-chen organizational owners are the only ones that can add external contributors, @CEHENKLE please help?~

We have an internal tool whereas those with admin access to repos can act on behalf of the organizational owner to invite external collaborators. I've invited @maxksyunz and @yury-fridlyand so we should be all set now.

dblock avatar Sep 12 '22 17:09 dblock

Screen Shot 2022-09-12 at 1 46 03 PM Screen Shot 2022-09-12 at 1 46 07 PM

dblock avatar Sep 12 '22 17:09 dblock

FYI @anirudha has the same level of access as me here, for next time

dblock avatar Sep 12 '22 17:09 dblock

FYI @anirudha has the same level of access as me here, for next time

Good to know that. Thanks for the help this time!

dai-chen avatar Sep 12 '22 18:09 dai-chen