opensearch-sdk-java icon indicating copy to clipboard operation
opensearch-sdk-java copied to clipboard

[FEATURE] Update Extension interface

Open minalsha opened this issue 3 years ago • 7 comments

Is your feature request related to a problem?

The getFeature(), createGuiceModules(), getGuiceServiceClasses(), additionalSettings(), getSettingsFilter(), getSettingUpgraders(), getIndexTemplateMetadataUpgrader(), getBootstrapChecks(), getRoles(), getAdditionalIndexSettingProviders() extension points communicate an extension's default capabilities to OpenSearch.

What solution would you like?

Update the Extension interface with the above methods, with default implementations matching Plugin.java.

minalsha avatar Jan 11 '23 20:01 minalsha

Hey, I would like to help complete this task.

Osiris34 avatar Jan 11 '23 20:01 Osiris34

Hey @Osiris34, welcome and feel free to implement this!

dbwiddis avatar Jan 11 '23 21:01 dbwiddis

Hi @Osiris34 welcome. Please help assign the issue to yourself and start working on it. Thanks

minalsha avatar Jan 11 '23 21:01 minalsha

@minalsha Hey where is the file you want updated located at?

Osiris34 avatar Jan 13 '23 15:01 Osiris34

Hey @Osiris34 the Extension interface is in the org.opensearch.sdk package. Here's the GitHub copy: https://github.com/opensearch-project/opensearch-sdk-java/blob/main/src/main/java/org/opensearch/sdk/Extension.java

dbwiddis avatar Jan 13 '23 16:01 dbwiddis

And here's the Plugin class to copy the default implementations from. Please change "plugin" to "extension" in the javadocs. https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/plugins/Plugin.java

dbwiddis avatar Jan 13 '23 17:01 dbwiddis

HI @Osiris34 , could you please share progress for this issue? Do you need any help with this issue?

minalsha avatar Feb 01 '23 04:02 minalsha