opensearch-plugins icon indicating copy to clipboard operation
opensearch-plugins copied to clipboard

[BUG] Sed commands in META.md do not work on mac

Open abhinavGupta16 opened this issue 4 years ago • 3 comments

What is the bug? The find and replace text commands using sed in https://github.com/opensearch-project/opensearch-plugins/blob/main/META.md does not work on mac

How can one reproduce the bug? run the find with sed commands on mac

What is the expected behavior? The commands should work as expected on linux and mac

What is your host/environment?

  • OS: Mac

abhinavGupta16 avatar Apr 05 '22 21:04 abhinavGupta16

I think for OSX you want to switch your sed to use gnu sed, https://stackoverflow.com/questions/30003570/how-to-use-gnu-sed-on-mac-os-10-10-brew-install-default-names-no-longer-su, otherwise it's endless pain of having sed that behaves differently on linux/mac. Maybe confirm and add a note?

dblock avatar Apr 05 '22 23:04 dblock

I think for OSX you want to switch your sed to use gnu sed, https://stackoverflow.com/questions/30003570/how-to-use-gnu-sed-on-mac-os-10-10-brew-install-default-names-no-longer-su, otherwise it's endless pain of having sed that behaves differently on linux/mac. Maybe confirm and add a note?

I am good with any solution that helps with mac

abhinavGupta16 avatar Apr 05 '22 23:04 abhinavGupta16

@abhinavGupta16 The fix here is to update the instructions and/or add a note on Mac.

dblock avatar Apr 11 '22 21:04 dblock