opensearch-java icon indicating copy to clipboard operation
opensearch-java copied to clipboard
verified publisher icon opensearch-project

Use own copy of PercentCodec for URI path encoding

Open Xtansia opened this issue 1 year ago • 2 comments

Description

Use own copy of PercentCodec for URI path encoding

Adapted from Apache HttpComponents HttpCore v5's https://github.com/apache/httpcomponents-core/blob/e009a923eefe79cf3593efbb0c18a3525ae63669/httpcore5/src/main/java/org/apache/hc/core5/net/PercentCodec.java

Issues Resolved

Fixes #1103

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Xtansia avatar Jul 25 '24 05:07 Xtansia

Can we add passing an optional encoder (without reflection) for backwards compatibility?

dblock avatar Jul 25 '24 12:07 dblock

Can we add passing an optional encoder (without reflection) for backwards compatibility?

For bwc, we need to make sure 2.x uses HCv4 encoding but 3.x uses HVv5 encoding, we could do that by class lookup.

reta avatar Jul 30 '24 12:07 reta

@Xtansia Can you please add to https://github.com/opensearch-project/opensearch-java/blob/main/UPGRADING.md and we can merge?

dblock avatar Jul 31 '24 15:07 dblock

Merged, backport accordingly?

dblock avatar Jul 31 '24 21:07 dblock