OpenSearch icon indicating copy to clipboard operation
OpenSearch copied to clipboard

Update skip versions for flat_object tests

Open msfroh opened this issue 1 year ago • 3 comments

Description

While fixing a flat_object bug, I noticed that we were skipping all related yamlRestTests on pre-3.0 versions. Since the flat object field type was added in 2.7, that should be the correct skip level for most tests. The bug I fixed is still present in 2.16 and earlier, so the test that covers that fix needs to be skipped pre-2.17.

Related Issues

https://github.com/opensearch-project/OpenSearch/pull/15431

Check List

  • [x] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

msfroh avatar Aug 27 '24 18:08 msfroh

:x: Gradle check result for 60ee8dae33a190d342b3016cd3e75b27c7f29293: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 27 '24 20:08 github-actions[bot]

:x: Gradle check result for 60ee8dae33a190d342b3016cd3e75b27c7f29293: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 27 '24 21:08 github-actions[bot]

:x: Gradle check result for 60ee8dae33a190d342b3016cd3e75b27c7f29293: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions[bot] avatar Aug 28 '24 06:08 github-actions[bot]

:white_check_mark: Gradle check result for 60ee8dae33a190d342b3016cd3e75b27c7f29293: SUCCESS

github-actions[bot] avatar Aug 28 '24 16:08 github-actions[bot]

@msfroh care to contribute some flat_object examples/schema/tests to https://github.com/opensearch-project/opensearch-api-specification?

dblock avatar Aug 29 '24 11:08 dblock