A typo in osgTerrain::GeometryPool::GeometryKey

[wadivision]

a typo

Hi Robert, I found a typo in file https://github.com/openscenegraph/OpenSceneGraph/blob/master/include/osgTerrain/GeometryPool#L117, in line 117 and line 118.I think you mean to write sy rather than sx.

a question

https://github.com/openscenegraph/OpenSceneGraph/blob/40bddd8d9532620dc704adce0d2fb0c854d62d0f/src/osgTerrain/GeometryPool.cpp#L64 I can't understand why the top_left is (1.0, 1.0, 0.0) ?

[robertosfield]

It does look like a bug. I'm surprised that it wasn't picked up before in testing.

On Wed, 13 Jan 2021 at 12:23, wadivision [email protected] wrote:

Hi Robert, I found a typo in file

https://github.com/openscenegraph/OpenSceneGraph/blob/master/include/osgTerrain/GeometryPool, in line 117 and line 118.I think you mean to write sy rather than sx.

In file https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/osgTerrain/GeometryPool.cpp ,line 64. I can't understand why the top_left is (1.0, 1.0, 0.0) ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openscenegraph/OpenSceneGraph/issues/1021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKEGUFWKCHAHE42XZROHMLSZWGETANCNFSM4WAXFMMQ .