open-scd icon indicating copy to clipboard operation
open-scd copied to clipboard

chore: fix husky, lint and format code

Open ca-d opened this issue 2 years ago • 4 comments

This fixes the husky installation to run pre-commit and commit-msg hooks again. This has not been working for a long time. Committing this also required fixing all linter errors, such that our code now actually lints again, and allowed me to finally run the formatter for the first time in ages, meaning we have linted and nicely formatted code again! :tada:

ca-d avatar Aug 03 '23 15:08 ca-d

Converted this to draft until https://github.com/openscd/open-scd/pull/1285 is merged, since this sits on top of that.

ca-d avatar Aug 03 '23 15:08 ca-d

Hi, I started doing as such fixes last month in my fork, here is the commit (still wip). I recommand using realworld project as it comes with many well-specified configuration.

samirromdhani avatar Nov 23 '23 17:11 samirromdhani

Hi, I started doing as such fixes last month in my fork

Thanks for considering this issue! I'm not sure I understand quite what you mean. Does your commit actually fix the husky pre-commit hook package? That is the topic of this pull request.

Your commit looks to me like it just includes a different eslint and prettier configuration, without actually fixing husky. If I'm not mistaken about that, be advised that this project already has a linter and formatter configuration, which follows the open-wc recommendation that this project was generated with.

ca-d avatar Nov 25 '23 10:11 ca-d

This PR has a lot of conflicts but I'd like to keep it around because we can cherry-pick the configs.

trusz avatar Jul 18 '24 08:07 trusz