linux icon indicating copy to clipboard operation
linux copied to clipboard

openrisc: Define screen_info in kernel setup

Open olofk opened this issue 10 years ago • 6 comments

olofk avatar Oct 29 '15 21:10 olofk

I have the same commit here: https://github.com/fjullien/linux/commit/0816f05a8943592df571e91e0cfd6cc196637f0c

However (I don't know if this is important), it depends on CONFIG_VGA_CONSOLE and CONFIG_DUMMY_CONSOLE. I must have copied this somewhere from any other architecture. You should take a look at this.

fjullien avatar Oct 29 '15 23:10 fjullien

Thanks Franck, Do you know if anyone actually uses this? I am thinking that Randy's patch here:

http://marc.info/?l=linux-kernel&m=147968525011508&w=2 <http://marc.info/?l=linux-kernel&m=147968525011508&w=2

which simply disables vga console for openrisc makes sense since we don't really support VGA console. If we will then I think we can move to your patch and have a test reference implementation.

stffrdhrn avatar Nov 30 '16 22:11 stffrdhrn

Atlys, neek and sockit systems use vga_lcd core which can be used to support VGA console. However I don't have a strong objection on Randy's patch.

fjullien avatar Dec 01 '16 06:12 fjullien

Me neither. It's more important to get things fixed upstream. We can keep a patch in our tree in the meantime

olofk avatar Dec 01 '16 07:12 olofk

Would those use VGA console? Or would they use fbconsole? I read though some old posts by Stefan and he specifcally mentioned "VGA". But to properly do it we would need to initialize the screen_info.

Lets check with stafan with what he meant by vga in IRC.

stffrdhrn avatar Dec 01 '16 07:12 stffrdhrn

As per conversation with Stefan:

< shorne> stekern: one other question I was meaning to ask, for your vga setup, did you ever use vgacon driver? or always fbcon?
< stekern> shorne: I don't think I've ever used vgacon

stffrdhrn avatar Jan 09 '17 06:01 stffrdhrn