visualisation-tool icon indicating copy to clipboard operation
visualisation-tool copied to clipboard

Minimal set of BODS features & properties required for a diagram to be rendered

Open kd-ods opened this issue 4 years ago • 5 comments

BODS doesn't need to be valid to be interpreted and rendered as a diagram by the visualiser.

There will be a minimal set of BODS features & properties required to make a diagram 'renderable', though. It should be made clear to users what that set is.

(As new visual features are added to the visualiser which are dependent on BODS data, it should be considered whether the related BODS property is added to the minimal set.)

kd-ods avatar Jan 25 '22 12:01 kd-ods

@Lathrisk - I hope this is an adequate expression of this issue :-/ Feel free to refine or clarify.

kd-ods avatar Jan 25 '22 12:01 kd-ods

I'm going to stash things on this issue which may relate to this work.

atm an image won't render if the BODS version (publicationDetails.bodsVersion) isn't the same for all statements in a BODS array.

kd-ods avatar Feb 14 '22 12:02 kd-ods

Dealing with this issue would help with #70 .

kd-ods avatar May 19 '22 14:05 kd-ods

@kd-ods @Lathrisk Dealing with this issue and https://github.com/openownership/visualisation-tool/issues/70 didn't make it into sprint 4 release, right? Let's discuss tomorrow

StephenAbbott avatar Jul 11 '22 09:07 StephenAbbott

@StephenAbbott - @Lathrisk put this together (see also this PR), which goes some way to achieving this. We should probably flag in the readme (cc @kd-ods)

lgs85 avatar Jul 11 '22 09:07 lgs85

Link now added to readme so closing issue

StephenAbbott avatar Jun 28 '24 14:06 StephenAbbott