copt icon indicating copy to clipboard operation
copt copied to clipboard

Update direction example is broken

Open fabianp opened this issue 5 years ago • 5 comments

The example https://github.com/openopt/copt/blob/master/examples/frank_wolfe/plot_vertex_overlap.py

(see output here )

does not produce the expected output.

@gideonite: do you want to take a look into it? This looks like a good issue to get familiar with the codebase

fabianp avatar Mar 10 '20 15:03 fabianp

Yes, interesting. I'll check it out! Sorry, somehow I missed that I was tagged in this issue! Feel free to assign to me.

gideonite avatar Mar 28 '20 13:03 gideonite

awesome, assigned

fabianp avatar Mar 29 '20 15:03 fabianp

Has this been fixed?

For away/pairwise, it would also be interesting to see the results. For pairwise, we may need to store the pair of vertices that are chosen.

GeoffNN avatar Jun 19 '20 10:06 GeoffNN

Shouldn't the overlap go back to 0 every time we change chosen vertex? Or are we plotting the cumulative sum right now?

GeoffNN avatar Jun 19 '20 10:06 GeoffNN

I tried to fix this in https://github.com/openopt/copt/pull/34. I think it's the cumulative sum, see https://github.com/openopt/copt/blob/master/examples/frank_wolfe/plot_vertex_overlap.py#L56

gideonite avatar Jun 19 '20 11:06 gideonite