web icon indicating copy to clipboard operation
web copied to clipboard

Translate main pages

Open ulasbayraktar opened this issue 1 year ago • 3 comments

ulasbayraktar avatar Apr 06 '24 02:04 ulasbayraktar

I come to the conclusion that this is not good.

  1. The keys are very long. Isn't this better?
"Index": {
  "Getting Started": "Getting started",
  "Fully backwards compatible with existing scripts and clients": "Fully backwards compatible with existing scripts and clients",
  
  "index-text-1": "Getting started",
  "index-text-2": "Fully backwards compatible with existing scripts and clients",

Or like this: https://github.com/openmultiplayer/launcher/blob/master/src/locales/translations/en.ts

  1. Announcements are temporary and old announcement remain in files after replacement. It will be difficult to remove them in the future.

But please don't make any changes for now, let other team members decide.

adib-yg avatar Apr 08 '24 02:04 adib-yg

I'm not entirely sure how I feel about introducing a new way for translations while docs use directory based files I also know that doing the same as docs for regular pages probably isn't doable, so there's that.

@Southclaws what are your thoughts on this?

AmyrAhmady avatar Apr 11 '24 11:04 AmyrAhmady

Barnaby had already said that it should be like this @AmyrAhmady (key-value)

ulasbayraktar avatar Apr 11 '24 11:04 ulasbayraktar