OpenML icon indicating copy to clipboard operation
OpenML copied to clipboard

Can't filter on default accuracy on website

Open amueller opened this issue 7 years ago • 11 comments

The default accuracy filter is broken, I think because the quality is not computed.

amueller avatar Nov 27 '18 23:11 amueller

@janvanrijn Does Fantail still compute this? It seems not, since this is empty: https://www.openml.org/a/data-qualities/DefaultAccuracy

joaquinvanschoren avatar Nov 28 '18 00:11 joaquinvanschoren

@janvanrijn Database search confirms that this is not computed.

joaquinvanschoren avatar Nov 28 '18 00:11 joaquinvanschoren

Could be that we removed it, since it is (without CV) the same as majorityClassPercentage. Shall we remove DefaultAccuracy from the DB?

janvanrijn avatar Nov 28 '18 00:11 janvanrijn

OK for me

joaquinvanschoren avatar Nov 28 '18 00:11 joaquinvanschoren

@amueller Is this the result you were expecting? https://www.openml.org/search?type=data&sort=qualities.MajorityClassPercentage&order=asc

joaquinvanschoren avatar Nov 28 '18 00:11 joaquinvanschoren

yeah I might have even argued that this is a better way to say it at some point ;) It would be good to replace it in the UI though. (making it a frontend issue again ;)

amueller avatar Nov 28 '18 04:11 amueller

I've deleted DefaultAccuracy from the search index. @janvanrijn: shall we remove it from the database as well?

joaquinvanschoren avatar Nov 28 '18 07:11 joaquinvanschoren

Ah, it was also in the filter options. I'll replace it.

joaquinvanschoren avatar Nov 28 '18 07:11 joaquinvanschoren

PR submitted: https://github.com/openml/OpenML/pull/892

@janvanrijn: we still need to delete it from the database, otherwise it will come back as a data quality in the next re-indexing.

joaquinvanschoren avatar Nov 28 '18 07:11 joaquinvanschoren

Yes. Also from the sql file.

janvanrijn avatar Nov 28 '18 14:11 janvanrijn

Doesn't seem to work?

amueller avatar Feb 20 '20 21:02 amueller