openmc-dev
Photonuclear Physics part 1
Description
This pull request is the first step of implementing photonuclear physics in OpenMC. This pull request handle definition and conversion of nuclear data from endf/ACE formatted libraries to hdf5 format. Because photonuclear physics is relatively a big feature, I feel that breaking it into chunks is preferable. I am open to constructive criticism regarding code structure, documentation, testing, etc.
Checklist
- [x] I have performed a self-review of my own code
- [x] I have run clang-format (version 15) on any C++ source files (if applicable)
- [x] I have followed the style guidelines for Python source files (if applicable)
- [x] I have made corresponding changes to the documentation (if applicable)
- [x] I have added tests that prove my fix is effective or that my feature works (if applicable)
Wow super to see work on this, it sounds like the PR would help fix a long standing issue of not being able to process TENDL gamma cross sections. https://github.com/openmc-dev/openmc/issues/1941
@makeclean Thanks for your review and suggested changes, most of which I accepted.
After including some tests I think this pr is ready for formal review.
@ahnaf-tahmid-chowdhury Thanks for your review! You noticed some things that I missed.
Currently the ci tests crash on the test: tests/regression_tests/deplete_decay_only/test.py::test_decay_only[coupled] This crash also happens to me when I test locally so I will update this branch when I will figure out what happens.