openmc-dev
fix - 2939
Adding basic contains functionality for cell in Geometry and Universe.
Fixes # (2939)
Checklist
- [x]x] I have performed a self-review of my own code
- [x] I have run clang-format (version 15) on any C++ source files (if applicable)
- [x] I have followed the style guidelines for Python source files (if applicable)
- [x] I have made corresponding changes to the documentation (if applicable)
- [x] I have added tests that prove my fix is effective or that my feature works (if applicable)
@MicahGale @paulromano @pshriwise Hi all... looks like we have a failure.
It looks the like unit_tests/test_tracks.py has failed which is outside the remit this fix. Thoughts all?
@paulromano @MicahGale Please take a look at this revised PR. Am I on the right track?
@MicahGale @paulromano next draft submitted. All tests have passed. Any thoughts?
@MicahGale approved? CI testing isn't done yet..... @paulromano @pshriwise thoughts?
@paulromano did you have any notes? I think @MicahGale is satisfied...?
@paulromano is something blocking the CI tests from running on my revised pull request? A few days ago I resolved the inconsistency in test_lib.py per your request and tried to run the CI testing. Over 2 days, 1 out of 12 tests passed with the rest just hanging. I mentioned it to @pshriwise this morning during the monthly meeting. He recommended I do another commit and resubmit the PR. The same thing seems to be happening.... Any advice?
@pshriwise did you open a separate pull request for this? I'm rerunning PR #3007 but I just was notified via email that a PR #4143 had failed https://github.com/openmc-dev/openmc/actions/runs/9387993834. This is PR for fix 2939 that you ran?
@pshriwise did you open a separate pull request for this? I'm rerunning PR #3007 but I just was notified via email that a PR #4143 had failed https://github.com/openmc-dev/openmc/actions/runs/9387993834. This is PR for fix 2939 that you ran?
Hi @caderache2014, I did rerun CI for the latest commit above with a CI job that ran all of the tests in an attempt to re-sync the CI triggers for this PR. I believe the number 4143 is in reference to something else, a value tracked by GitHub actions I'd wager, as our PR/Issue index hasn't gotten quite that high yet.
