openmc icon indicating copy to clipboard operation
openmc copied to clipboard

Feature request: Creating statepoint printout to include relative path

Open shimwell opened this issue 2 years ago • 3 comments

When running an openmc simulation we get a nice message that tells us where the statepoint is saved

 Simulating batch 18
 Simulating batch 19
 Simulating batch 20
 Creating state point statepoint.20.h5...

If this simulation has been run using openmc.run(cwd='my_outputs') then it might be nice to include that relative path in the terminal output so it would look like this

 Simulating batch 18
 Simulating batch 19
 Simulating batch 20
 Creating state point my_outputs/statepoint.20.h5...

I just suffered a bit by opening a statepoint.20.h5 that was in the local folder instead of one that was in my output folder so I'm thinking this change might save other users from the same user mistake I made.

I believe this is one of the lines that would need changing https://github.com/openmc-dev/openmc/blob/6e2a9add5ef5019147e20422c380900c9b4a21a4/src/state_point.cpp#L54 but I don't know how it would access the cwd variable from the python side

shimwell avatar Feb 17 '23 13:02 shimwell

Hi, we a pair of students from EECS 481 at the University of Michigan, and we would love the opportunity to work on this issue. Could you assign it to us if it is still open? Thank you

xinzhouhe avatar Mar 31 '24 22:03 xinzhouhe

Thanks @xinzhouhe feel free to have a crack at this one

shimwell avatar Apr 01 '24 03:04 shimwell

Thanks, we will look into the issue and work on it as soon as possible.


From: Jonathan Shimwell @.> Sent: Sunday, March 31, 2024 11:58 PM To: openmc-dev/openmc @.> Cc: Daniel He @.>; Mention @.> Subject: Re: [openmc-dev/openmc] Feature request: Creating statepoint printout to include relative path (Issue #2393)

Thanks @xinzhouhehttps://github.com/xinzhouhe feel free to have a crack at this one

— Reply to this email directly, view it on GitHubhttps://github.com/openmc-dev/openmc/issues/2393#issuecomment-2029116362, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW72N5CEER4O2464CZGRBTLY3DLNTAVCNFSM6AAAAAAU7NEKNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGEYTMMZWGI. You are receiving this because you were mentioned.Message ID: @.***>

xinzhouhe avatar Apr 01 '24 04:04 xinzhouhe

@shimwell I don't think what you're proposing is possible. The executable is called from the specified working directory and doesn't have any knowledge of what the original directory was.

paulromano avatar Jun 19 '24 13:06 paulromano

ah fair enough, I think we can close this issue / request then. Feel free to reopen if anyone has a work around

shimwell avatar Jun 19 '24 14:06 shimwell