jmc icon indicating copy to clipboard operation
jmc copied to clipboard

6683: Mouse over for Event Thread should show the various thread IDs

Open viragpurnam opened this issue 1 year ago • 3 comments

Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view.

Before: No information on Hover EventThread_Before

After: Thread Id shown on Hover EventThread_After

Before: Only Thread Description shown in properties view Properties_Before

After: Along with Thread Description, Thread Id also shown in properties view Properties_After

Could you please review the changes? Please suggest if anything more is needed with this enhancement request.


Progress

  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-6683: Mouse over for Event Thread should show the various thread IDs (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/593/head:pull/593
$ git checkout pull/593

Update a local copy of the PR:
$ git checkout pull/593
$ git pull https://git.openjdk.org/jmc.git pull/593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 593

View PR using the GUI difftool:
$ git pr show -t 593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/593.diff

Webrev

Link to Webrev Comment

viragpurnam avatar Oct 18 '24 09:10 viragpurnam

:wave: Welcome back vpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 18 '24 09:10 bridgekeeper[bot]

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6683: Mouse over for Event Thread should show the various thread IDs

Reviewed-by: aptmac, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 92fe6812699c842bd30451872b1cb0948d204333: 8287: Fix the JMX protocol extenders
  • 9370abed09c5995b5fc522a4cd2472104060133c: 8219: Missing coverage in application reports
  • 7135063b969e65035e369255a602fb1a10f31d2e: 6626: The halt rule result should have a table of the VM operations
  • 6c244aef61a5d05a74a78dfda49ce92e2aa48982: 8285: Documentation fix
  • 5c49e6b5127d7ffe9866d96ed3d5a94c62e8ab79: 8277: List ARM first
  • 10c01dc07fd7207339077626fe62fec5413c32f5: 8282: Spotbugs errors
  • 9e3bbaa55fafc9ca9a36148076428557ea008f64: 8276: UI tests failing on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Oct 18 '24 09:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 18 '24 09:10 mlbridge[bot]

Hi @viragpurnam! This can be integrated now!

thegreystone avatar Nov 04 '24 23:11 thegreystone

Hi @viragpurnam! This can be integrated now!

Thanks @thegreystone and @aptmac for reviews. Integrating this PR.

viragpurnam avatar Nov 05 '24 04:11 viragpurnam

/integrate

viragpurnam avatar Nov 05 '24 04:11 viragpurnam

Going to push as commit fadc2607b3355e39cf859445732429ebfd6355b9. Since your change was applied there have been 8 commits pushed to the master branch:

  • 45b2a4ba12edd54d0533221d4b09ad808057b2ba: 8288: Clean up warnings
  • 92fe6812699c842bd30451872b1cb0948d204333: 8287: Fix the JMX protocol extenders
  • 9370abed09c5995b5fc522a4cd2472104060133c: 8219: Missing coverage in application reports
  • 7135063b969e65035e369255a602fb1a10f31d2e: 6626: The halt rule result should have a table of the VM operations
  • 6c244aef61a5d05a74a78dfda49ce92e2aa48982: 8285: Documentation fix
  • 5c49e6b5127d7ffe9866d96ed3d5a94c62e8ab79: 8277: List ARM first
  • 10c01dc07fd7207339077626fe62fec5413c32f5: 8282: Spotbugs errors
  • 9e3bbaa55fafc9ca9a36148076428557ea008f64: 8276: UI tests failing on Windows

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Nov 05 '24 04:11 openjdk[bot]

@viragpurnam Pushed as commit fadc2607b3355e39cf859445732429ebfd6355b9.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Nov 05 '24 04:11 openjdk[bot]