jextract icon indicating copy to clipboard operation
jextract copied to clipboard

7904089: jextract cannot handle "void foo(int foo)"

Open nizarbenalla opened this issue 6 months ago • 3 comments

Please review this change to fix a name conflicts between functions and name parameters.

TIA!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Change must be properly reviewed (no review required)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jextract.git pull/292/head:pull/292
$ git checkout pull/292

Update a local copy of the PR:
$ git checkout pull/292
$ git pull https://git.openjdk.org/jextract.git pull/292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 292

View PR using the GUI difftool:
$ git pr show -t 292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jextract/pull/292.diff

Using Webrev

Link to Webrev Comment

nizarbenalla avatar Oct 15 '25 11:10 nizarbenalla

:wave: Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Oct 15 '25 11:10 bridgekeeper[bot]

@nizarbenalla This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7904089: jextract cannot handle "void foo(int foo)"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Oct 15 '25 11:10 openjdk[bot]

Webrevs

mlbridge[bot] avatar Oct 15 '25 11:10 mlbridge[bot]

@nizarbenalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Nov 12 '25 21:11 bridgekeeper[bot]