jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324

Open kurashige23 opened this issue 11 months ago • 3 comments

Hi all,

This PR fixes the wrong version of Xerces-J. The version of Xerces-J became 2.7.1 in JDK-7150324, but it is 2.10.0 in THIRD_PARTY_README. Just fix THIRD_PARTY_README, no risk.

Thanks


Progress

  • [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [ ] JDK-8351624 needs maintainer approval
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue

Issue

  • JDK-8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/636/head:pull/636
$ git checkout pull/636

Update a local copy of the PR:
$ git checkout pull/636
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 636

View PR using the GUI difftool:
$ git pr show -t 636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/636.diff

Using Webrev

Link to Webrev Comment

kurashige23 avatar Mar 11 '25 08:03 kurashige23

:wave: Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Mar 11 '25 08:03 bridgekeeper[bot]

@kurashige23 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • bf1754263cffbe07fc1e84d38b839177b173cc16: 8358328: Bump update version of OpenJDK: 8u472
  • 6f0f298a77e881e1ea7a222240514ae3fc19ade2: 8340387: Update OS detection code to recognize Windows Server 2025
  • a01bf3180fe943be81529408b9208ee992336be1: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/79124139a676a555511f4365ce6771a7dc920dcf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Mar 11 '25 08:03 openjdk[bot]

Webrevs

mlbridge[bot] avatar Mar 11 '25 08:03 mlbridge[bot]

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Apr 08 '25 15:04 bridgekeeper[bot]

Could anyone review this PR please?

kurashige23 avatar Apr 09 '25 09:04 kurashige23

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 07 '25 11:05 bridgekeeper[bot]

Could anyone review this PR please?

kurashige23 avatar May 08 '25 09:05 kurashige23

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jun 05 '25 11:06 bridgekeeper[bot]

@jerboaa

I'm sorry to bother you suddenly, but could you please review this PR? Or could you assign a reviewer? I'm having trouble because I haven't had any reviewers for a while.

Thanks.

kurashige23 avatar Jun 08 '25 23:06 kurashige23

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jun 10 '25 10:06 openjdk[bot]

Thank you for your review!

/approval request The version of Xerces-J is wrong in THIRD_PARTY_README after JDK-7150324, so I fxied it. Just fix THIRD_PARTY_README, no risk.

kurashige23 avatar Jun 10 '25 12:06 kurashige23

@kurashige23 8351624: The approval request has been created successfully.

openjdk[bot] avatar Jun 10 '25 12:06 openjdk[bot]

/integrate

kurashige23 avatar Jun 10 '25 13:06 kurashige23

@kurashige23 Your change (at version 70e695ea9602801326b9354a583ee08703c59ae7) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Jun 10 '25 13:06 openjdk[bot]

/sponsor

jerboaa avatar Jun 10 '25 14:06 jerboaa

Going to push as commit 4f9234206475401978f3cc33286cbc41f2c8bc1b. Since your change was applied there have been 40 commits pushed to the master branch:

  • bf1754263cffbe07fc1e84d38b839177b173cc16: 8358328: Bump update version of OpenJDK: 8u472
  • 6f0f298a77e881e1ea7a222240514ae3fc19ade2: 8340387: Update OS detection code to recognize Windows Server 2025
  • a01bf3180fe943be81529408b9208ee992336be1: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/79124139a676a555511f4365ce6771a7dc920dcf...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Jun 10 '25 14:06 openjdk[bot]

@jerboaa @kurashige23 Pushed as commit 4f9234206475401978f3cc33286cbc41f2c8bc1b.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Jun 10 '25 14:06 openjdk[bot]