jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard

8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option

Open mrserb opened this issue 1 year ago • 6 comments

Hi all,

This pull request contains a backport of commit 0abb2b14 from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon.

Thanks!


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8030795 needs maintainer approval

Issue

  • JDK-8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/533/head:pull/533
$ git checkout pull/533

Update a local copy of the PR:
$ git checkout pull/533
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 533

View PR using the GUI difftool:
$ git pr show -t 533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/533.diff

Webrev

Link to Webrev Comment

mrserb avatar Jul 03 '24 04:07 mrserb

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jul 03 '24 04:07 bridgekeeper[bot]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option

Reviewed-by: aph, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 7d36fed8e01c6ee0a1b301a379df5dae8afa960d: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 49425166c201e73dd954bd033ea6e33f4a9811b3: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3c19f1276e92c6955600730b8d3353c4ea: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad460815f2637d53df37b27b68e64d5b75b: 8318951: Additional negative value check in JPEG decoding
  • aa443466bbe5f8326ab595ef9f4a2fa9919250e9: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • fc33f51c24d21e30a73ce3a70ba961651b483672: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d017b18ad7cd8842b9324c5c031a44a58064: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201af69a500b06a345f84a5b1ce550b605b2: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/54f7734c7cea3a20d49103c4387ed9023992e5a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Jul 03 '24 04:07 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jul 03 '24 04:07 openjdk[bot]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jul 03 '24 04:07 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jul 03 '24 05:07 mlbridge[bot]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 31 '24 05:07 bridgekeeper[bot]

keep open

mrserb avatar Aug 12 '24 17:08 mrserb

/approve yes

gnu-andrew avatar Aug 28 '24 00:08 gnu-andrew

@gnu-andrew 8030795: The approval request has been approved.

openjdk[bot] avatar Aug 28 '24 00:08 openjdk[bot]

/integrate

mrserb avatar Aug 28 '24 22:08 mrserb

Going to push as commit 7c13bd84274ffdd437ffcc3b39694f9efce0ec1b. Since your change was applied there have been 47 commits pushed to the master branch:

  • 7d36fed8e01c6ee0a1b301a379df5dae8afa960d: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
  • 49425166c201e73dd954bd033ea6e33f4a9811b3: 8278794: Infinite loop in DeflaterOutputStream.finish()
  • 89697c3c19f1276e92c6955600730b8d3353c4ea: 8334653: ISO 4217 Amendment 177 Update
  • 9a426ad460815f2637d53df37b27b68e64d5b75b: 8318951: Additional negative value check in JPEG decoding
  • aa443466bbe5f8326ab595ef9f4a2fa9919250e9: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
  • fc33f51c24d21e30a73ce3a70ba961651b483672: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 8867d017b18ad7cd8842b9324c5c031a44a58064: 8193682: Infinite loop in ZipOutputStream.close()
  • 5c7f201af69a500b06a345f84a5b1ce550b605b2: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
  • 933c78ebd5be5aedc2181b95917933dffe7e279c: 8309138: Fix container tests for jdks with symlinked conf dir
  • 4fe22e82ebd3640c7999e094903874c9ac7f2391: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
  • ... and 37 more: https://git.openjdk.org/jdk8u-dev/compare/54f7734c7cea3a20d49103c4387ed9023992e5a6...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Aug 28 '24 23:08 openjdk[bot]

@mrserb Pushed as commit 7c13bd84274ffdd437ffcc3b39694f9efce0ec1b.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Aug 28 '24 23:08 openjdk[bot]