8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

[mrserb]

Hi all,

This pull request contains a backport of commit 40e667c1 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov.

Thanks!

---

Progress

• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-8239312 needs maintainer approval

Issue

• JDK-8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/531/head:pull/531
$ git checkout pull/531

Update a local copy of the PR:
$ git checkout pull/531
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 531

View PR using the GUI difftool:
$ git pr show -t 531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/531.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java

Reviewed-by: aph, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 503ae0b0637ad70e47240df2b7c2a546e8653e5a: 8339394: Bump update version of OpenJDK: 8u442
• e32d62e2a39510f643b32d615e76f0ff9be3d9f3: 8298887: On the latest macOS+XCode the Robot API may report wrong colors
• 8b0fedccb89308b7dfdf1ab7c7801b4e3a786ec2: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mrserb]

/clean The patch is identical to openjdk/jdk.

[openjdk[bot]]

@mrserb This backport pull request is now marked as clean

[openjdk[bot]]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (7dd33590)
• 00: Full (6ec6e798)

[bridgekeeper[bot]]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

keep open

[gnu-andrew]

This is a MacOS patch but the GHA MacOS build has not been run. Please merge with the current jdk8u-dev so that the Mac build runs before we approve this patch. It should be working now (see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/10619513292/job/29437308137 for example)

[mrserb]

This is a MacOS patch but the GHA MacOS build has not been run. Please merge with the current jdk8u-dev so that the Mac build runs before we approve this patch. It should be working now (see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/10619513292/job/29437308137 for example)

done. There are some known failed tests: ".../CertPathValidator/certification/CAInterop#..."

[phohensee]

All the GHA failures but one are cert issues that look unrelated. For that one (MacOS-x64 hotspot/test/compiler/unsafe/OpaqueAccesses.java) I merged the patch with the latest upstream 8u and ran it on my Intel Mac laptop and it passed. So did the modified test.

[gnu-andrew]

All the GHA failures but one are cert issues that look unrelated.

Yes, same as noted on #516. We should exclude them. They fail on trunk too.

For that one (MacOS-x64 hotspot/test/compiler/unsafe/OpaqueAccesses.java) I merged the patch with the latest upstream 8u and ran it on my Intel Mac laptop and it passed. So did the modified test.

Shouldn't @mrserb's merge mean that GHA was run against latest upstream 8u-dev too? Maybe the test fails sporadically?

I'm approving this but please don't push until 8u442 is open.

/approve yes

[openjdk[bot]]

@gnu-andrew 8239312: The approval request has been approved.

[phohensee]

It does seem that this PR was merged with the latest upstream and ran GHA.

[mrserb]

/integrate

[openjdk[bot]]

Going to push as commit 068ed1f551d917d9ccf4c1d52862785a28dc1ff8. Since your change was applied there have been 4 commits pushed to the master branch:

• cb95a72ec972a952e49913757887b534ed95fd5d: 8260380: Upgrade to LittleCMS 2.12
• 503ae0b0637ad70e47240df2b7c2a546e8653e5a: 8339394: Bump update version of OpenJDK: 8u442
• e32d62e2a39510f643b32d615e76f0ff9be3d9f3: 8298887: On the latest macOS+XCode the Robot API may report wrong colors
• 8b0fedccb89308b7dfdf1ab7c7801b4e3a786ec2: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@mrserb Pushed as commit 068ed1f551d917d9ccf4c1d52862785a28dc1ff8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.