6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure

[ktakakuri]

Hi all,

I would like to backport this patch to improve test maintainability. Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. Given this, the @debuggeeVMOptions mechanism can be safely removed. The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.

There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue
• [ ] JDK-6622468 needs maintainer approval

Issue

• JDK-6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure (Bug - P4 - Requested)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/492/head:pull/492
$ git checkout pull/492

Update a local copy of the PR:
$ git checkout pull/492
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 492

View PR using the GUI difftool:
$ git pr show -t 492

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/492.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[openjdk[bot]]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge[bot]]

Webrevs

• 00: Full (6f1ae0bc)

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[ktakakuri]

Could someone please review this backport?

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[ktakakuri]

/open

[openjdk[bot]]

@ktakakuri This pull request is now open

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

Could someone please review this backport?

[openjdk[bot]]

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[ktakakuri]

/approval request I would like to backport this patch for test maintainability in JDK8. The backport is clean except for one test which has already been fixed. The risk is low as this only touches tests. There is a related patch JDK-8048892 and the corresponding backport has been submitted. Testing: All tests under jdk/test/com/sun/jdi

[openjdk[bot]]

@ktakakuri 6622468: The approval request has been created successfully.