jdk8u-dev 8235834: IBM-943 charset encoder needs updating

Backporting JDK-8235834 - IBM-943 charset encoder needs updating. There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Progress

[ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
[ ] JDK-8235834 needs maintainer approval
[x] Change must not contain extraneous whitespace
[x] Commit message must refer to an issue

Issue

JDK-8235834: IBM-943 charset encoder needs updating (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476
$ git checkout pull/476

Update a local copy of the PR:
$ git checkout pull/476
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 476

View PR using the GUI difftool:
$ git pr show -t 476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/476.diff

Webrev

Link to Webrev Comment

Apr 01 '24 10:04 psawant19

Hi @psawant19, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user psawant19" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

Apr 01 '24 10:04 bridgekeeper[bot]

This contribution is on behalf of my employer, IBM, which is a corporate OCA signatory.

Apr 01 '24 10:04 psawant19

/covered

Apr 01 '24 10:04 psawant19

@psawant19 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235834: IBM-943 charset encoder needs updating

Apply 34B003AF.RPMAP130 definition into encoder

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Apr 01 '24 10:04 openjdk[bot]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

Apr 01 '24 10:04 bridgekeeper[bot]

/covered

Apr 02 '24 06:04 psawant19

Already processed the covered command

Apr 02 '24 06:04 bridgekeeper[bot]

/covered

Apr 08 '24 04:04 psawant19

Already processed the covered command

Apr 08 '24 04:04 bridgekeeper[bot]

Closing this PR as my OCA verification is taking too long to approve. Opened another PR by a different contributor:- https://github.com/openjdk/jdk8u-dev/pull/480.

Apr 15 '24 09:04 psawant19

/covered

Apr 29 '24 04:04 psawant19

You are already a known contributor!

Apr 29 '24 04:04 bridgekeeper[bot]

Backporting JDK-8235834 - IBM-943 charset encoder needs updating. There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834.

Apr 29 '24 04:04 psawant19

This backport pull request has now been updated with issue and summary from the original commit.

Apr 29 '24 04:04 openjdk[bot]

Webrevs

Apr 29 '24 04:04 mlbridge[bot]

@gnu-andrew, @mrserb Could you please review this PR.

Apr 29 '24 04:04 psawant19

Hi @psawant19 , This PR doesn't make any sense if https://github.com/openjdk/jdk8u-dev/pull/480 is in review. Please close one of them.

May 03 '24 13:05 offamitkumar

/clean The patch is identical to the patch in jdk11u-dev.

May 06 '24 11:05 psawant19

@psawant19 Only OpenJDK Committers can use the /clean command

May 06 '24 11:05 openjdk[bot]

Please merge master branch and that should trigger the GHA test again.

May 13 '24 06:05 offamitkumar

Failures are a Certigna certificate test and an Ubuntu packages not available at specified path. Hence integrating. /integrate

May 13 '24 11:05 psawant19

@psawant19 This pull request has not yet been marked as ready for integration.

May 13 '24 11:05 openjdk[bot]

/integrate

@psawant19, Please go through the contribution guidelines. Don't just integrate!!

There is progress check list on your PR. Once all of them are marked as completed. Then only you should go for integration.

So for now, You need:

approval from Rivewer.
approval from Maintainer.

Failures are a Certigna certificate test and an Ubuntu packages not available at specified path. Hence integrating.

I asked you to merge master branch in psawant19:IBM943-support-backport-1b9251 so that Github will run the test cases again. Please do it!!

May 13 '24 11:05 offamitkumar

I guess something went wrong with GHA test. Have you turned off Github Actions ?

@RealCLanger is it possible to get review from you ?

May 15 '24 11:05 offamitkumar

@RealCLanger is it possible to get review from you ?

No, not really. We at SAP are not engaged in jdk8 updates since quite some time and also have no infrastructure around to test. I'd recommend you to ask some Red Hat folks for help, e.g. @jerboaa

May 15 '24 11:05 RealCLanger

@jerboaa, I have fixed the compilation error and GHAs are enabled on this repo. IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm

Attaching test evidences for the bug fix with before and after screenshots.

Before fix:

After fix:

May 16 '24 07:05 psawant19

@psawant19 Thanks. Please also show that the sun/nio/cs jtreg tests are passing.

May 16 '24 08:05 jerboaa

I have fixed the compilation error and GHAs are enabled on this repo.

Please merge lastest master into your branch, which should make the certinga CA tests failure go away.

May 16 '24 08:05 jerboaa

⚠️ @psawant19 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

May 16 '24 08:05 openjdk[bot]

@jerboaa, There is still 1 pre-test failing that is because these below packages doesn't exist at this location.

https://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
https://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages

Is the PR good to go for maintainer approval?

May 16 '24 11:05 psawant19