8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612

[ktakakuri]

Hi all,

This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612
The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.

The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.

Thank you.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [ ] JDK-8217850 needs maintainer approval
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #431 must be integrated first

Issue

• JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/433/head:pull/433
$ git checkout pull/433

Update a local copy of the PR:
$ git checkout pull/433
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 433

View PR using the GUI difftool:
$ git pr show -t 433

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/433.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into pr/431 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

This backport pull request has now been updated with issue from the original commit.

[mlbridge[bot]]

Webrevs

• 01: Full - Incremental (be3e6030)
• 00: Full (ccb8463a)

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[openjdk[bot]]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

[ktakakuri]

Could someone please review this backport? I have merged master branch to resolve the GHA error. Once #431 is merged, these diffs will disappear. The only fix I put in this backport is https://github.com/openjdk/jdk8u-dev/pull/433/commits/ccb8463a09dc09a6df363017a350c8bc00fcbd60.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

Can someone please review this backport?

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

Could anyone please review this fix?

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

Could someone please review this backport with #431?

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request of #431. I comment to not close.

[bridgekeeper[bot]]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[ktakakuri]

This pull request is pending approval of the Fix Request of https://github.com/openjdk/jdk8u-dev/pull/431. I comment to not close.