jdk8u-dev icon indicating copy to clipboard operation
jdk8u-dev copied to clipboard
verified publisher icon openjdk

8248001: javadoc generates invalid HTML pages whose ftp:// links are broken

Open ktakakuri opened this issue 2 years ago • 31 comments

I would like to backport 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. There are minor differences regarding DocRoot, but otherwise this is a clean backport.

Progress

  • [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] JDK-8248001 needs maintainer approval

Issue

  • JDK-8248001: javadoc generates invalid HTML pages whose ftp:// links are broken (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/420/head:pull/420
$ git checkout pull/420

Update a local copy of the PR:
$ git checkout pull/420
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/420/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 420

View PR using the GUI difftool:
$ git pr show -t 420

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/420.diff

Using Webrev

Link to Webrev Comment

ktakakuri avatar Jan 16 '24 02:01 ktakakuri

:wave: Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Jan 16 '24 02:01 bridgekeeper[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Jan 16 '24 02:01 openjdk[bot]

Webrevs

mlbridge[bot] avatar Jan 16 '24 02:01 mlbridge[bot]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Feb 13 '24 07:02 bridgekeeper[bot]

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

bridgekeeper[bot] avatar Mar 12 '24 11:03 bridgekeeper[bot]

/open

ktakakuri avatar Mar 25 '24 02:03 ktakakuri

@ktakakuri This pull request is now open

openjdk[bot] avatar Mar 25 '24 02:03 openjdk[bot]

❗ This change is not yet ready to be integrated. See the Progress checklist in the description for automated requirements.

openjdk[bot] avatar Mar 25 '24 02:03 openjdk[bot]

Could anyone review this backport please? This is a simple fix, almost a clean backport.

ktakakuri avatar Apr 18 '24 09:04 ktakakuri

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar May 16 '24 14:05 bridgekeeper[bot]

Can someone please review this backport?

ktakakuri avatar May 21 '24 08:05 ktakakuri

⚠️ @ktakakuri This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Jun 10 '24 17:06 openjdk[bot]

/approval request There are minor differences regarding DocRoot, but otherwise this is a clean backport. There is no risk, because the logic around the changes and the cause of the problem is the same as in jdk18. Testing: test/langtools on Windows x86_64

ktakakuri avatar Jun 12 '24 05:06 ktakakuri

@ktakakuri 8248001: The approval request has been created successfully.

openjdk[bot] avatar Jun 12 '24 05:06 openjdk[bot]

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Jul 10 '24 09:07 bridgekeeper[bot]

This pull request is pending approval of the Fix Request. I comment to not close.

ktakakuri avatar Aug 05 '24 12:08 ktakakuri

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Sep 02 '24 13:09 bridgekeeper[bot]

This pull request is pending approval of the Fix Request. I comment to not close.

ktakakuri avatar Sep 03 '24 11:09 ktakakuri

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper[bot] avatar Oct 01 '24 13:10 bridgekeeper[bot]

This pull request is pending approval of the Fix Request. I comment to not close.

ktakakuri avatar Oct 02 '24 09:10 ktakakuri