jdk17u-dev icon indicating copy to clipboard operation
jdk17u-dev copied to clipboard

8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically

Open GoeLin opened this issue 3 months ago • 5 comments

I backport this for parity with 17.0.18-oracle.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] JDK-8325766 needs maintainer approval

Issue

  • JDK-8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4153/head:pull/4153
$ git checkout pull/4153

Update a local copy of the PR:
$ git checkout pull/4153
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4153

View PR using the GUI difftool:
$ git pr show -t 4153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4153.diff

Using Webrev

Link to Webrev Comment

GoeLin avatar Nov 04 '25 11:11 GoeLin

:wave: Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Nov 04 '25 11:11 bridgekeeper[bot]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325766: Extend CertificateBuilder to create trust and end entity certificates programmatically

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 3bddec8f8150efb1e022c4a3943777adda96f1ef: 8352687: Opensource few JInternalFrame and JTextField tests
  • f678c6611125348d48c4d5c4bae7fe361a1d264c: 8352905: Open some JComboBox bugs 1
  • 76a55f23e3f9e70514b189c3ff75ac68085216be: 8355561: [macos] Build failure with Xcode 16.3
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/a3442fd77f524a2ccbb499ab0120b11c30642708...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar Nov 04 '25 11:11 openjdk[bot]

This backport pull request has now been updated with issue from the original commit.

openjdk[bot] avatar Nov 04 '25 11:11 openjdk[bot]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

openjdk[bot] avatar Nov 04 '25 11:11 openjdk[bot]

Webrevs

mlbridge[bot] avatar Nov 04 '25 11:11 mlbridge[bot]

/integrate

GoeLin avatar Nov 06 '25 10:11 GoeLin

Going to push as commit 9dbee307410971bbc46c52d18e9ef0134c736c5f. Since your change was applied there have been 6 commits pushed to the master branch:

  • 7fe25530c47cacc11c5214ef7ef4db443701eabf: 8369226: GHA: Switch to MacOS 15
  • 3bddec8f8150efb1e022c4a3943777adda96f1ef: 8352687: Opensource few JInternalFrame and JTextField tests
  • f678c6611125348d48c4d5c4bae7fe361a1d264c: 8352905: Open some JComboBox bugs 1
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/a3442fd77f524a2ccbb499ab0120b11c30642708...master

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Nov 06 '25 10:11 openjdk[bot]

@GoeLin Pushed as commit 9dbee307410971bbc46c52d18e9ef0134c736c5f.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Nov 06 '25 10:11 openjdk[bot]