8350540: [17u,11u] B8312065.java fails Network is unreachable

[sendaoYan]

Hi all,

Test test/jdk/java/net/Socket/B8312065.java fails on some machines. Test assume 192.168.255.255 is not in use, but on some machines linux command ping 192.168.255.255 will report "ping: connect: Network is unreachable" failure, so this test will report "java.net.ConnectException: Network is unreachable (connect failed)" failure. And this failure is not caused by JDK bug, so I think it's better throw jtreg.SkippedException when this failure reported.

Change has been verified locally, test-fix only to make test more robustness, no risk.

---

Progress

• [x] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [ ] JDK-8350540 needs maintainer approval
• [x] Commit message must refer to an issue

Issue

• JDK-8350540: [17u,11u] B8312065.java fails Network is unreachable (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3293/head:pull/3293
$ git checkout pull/3293

Update a local copy of the PR:
$ git checkout pull/3293
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3293/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3293

View PR using the GUI difftool:
$ git pr show -t 3293

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3293.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350540: [17u,11u] B8312065.java fails Network is unreachable

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 243 new commits pushed to the master branch:

• af0de21b9bac2b593e2b50703e2995cd7a9cfb42: 8330598: java/net/httpclient/Http1ChunkedTest.java fails with java.util.MissingFormatArgumentException: Format specifier '%s'
• 1edd6660f657300337bdcdc6d78618e02b60592d: 8352706: httpclient HeadTest does not run on HTTP2
• 3a9b28f59095ecee861a037c237a194e0218397a: 8343891: Test javax/swing/JTabbedPane/TestJTabbedPaneBackgroundColor.java failed
• ... and 240 more: https://git.openjdk.org/jdk17u-dev/compare/2846c9e07b4502f2cc0c823b97c889f1440c66a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 00: Full (2ee3a450)

[GoeLin]

Hi @sensaYan, why doesn't this apply to head and jdk21?

[sendaoYan]

Hi @sensayan, why doesn't this apply to head and jdk21?

Hi @GoeLin Test test/jdk/java/net/Socket/B8312065.java was add by JDK-8312065, and this test only added for jdk17u-dev and jdk11u-dev.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

Hi, can anyone take look this PR.

[openjdk[bot]]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[bridgekeeper[bot]]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

@phohensee Thanks for the reviews.

[sendaoYan]

/approval request Fix the test bug which may cause test fails on some special machines. Change has been verified locally, test-fix only to make test more robustness, no risk.

[openjdk[bot]]

@sendaoYan 8350540: The approval request has been created successfully.

[sendaoYan]

Thanks for the approved.

/integrate

[openjdk[bot]]

Going to push as commit 75fa2e7c44d52874fa0054889f1240e0c58fcfd1. Since your change was applied there have been 250 commits pushed to the master branch:

• e5599624c23c0f8c8d5ceff5eb9fd79ad0f302a5: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
• 9abc9cefaf22110899a87b80f254fc9d0b10606e: 8303549: [AIX] TestNativeStack.java is failing with exit value 1
• 22c205d3f1f342306fd391197c005a39a812cd20: 8295670: Remove duplication in java/util/Formatter/Basic*.java
• ... and 247 more: https://git.openjdk.org/jdk17u-dev/compare/2846c9e07b4502f2cc0c823b97c889f1440c66a6...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@sendaoYan Pushed as commit 75fa2e7c44d52874fa0054889f1240e0c58fcfd1.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.